fix(cli): Gen-creds should not try to read existing#564
Closed
BYK wants to merge 1 commit into
Closed
Conversation
When `--stdout` is passed `generate credentials` still try to read the existing credentials and complain if they exist, requiring `--overwrite` to be passed and failing if the file is not readable. This should not happen with `--stdout` as there's no chance of accidental data loss.
jan-auer
changed the title
untitaker
approved these changes
Apr 28, 2020
Member
|
We decided to go with a larger refactor of the config system, instead. We can leave this open a starting point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
--stdoutis passedgenerate credentialsstill try to read the existing credentials and complain if they exist, requiring--overwriteto be passed and failing if the file is not readable. This should not happen with--stdoutas there's no chance of accidental data loss.