fix(spans): Infer names PII-safely - #6112
Merged
Merged
Conversation
Dav1dde
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When inferring names for V1 spans, PII has to be taken into account. This means that unconditionally inferring names during V1 -> V2 conversion, as we do now, is unsafe—it's fine for spans that have gone through PII scrubbing (to wit, standalone spans that have gone through the legacy pipeline, as well as spans extracted from transactions), but for standalone spans we have to do it later.
This addresses the problem in the following ways:
span_v1_to_span_v2for whether to infer a name.infer_nameflag to span processing settings, controlling whether names should be inferred in the pipeline. This is disabled for V2 spans but enabled for legacy spans.With this PR, name inference is now PII-safe in all cases:
Closes INGEST-957.