ref(managed): Implement Managed::zip function

[pierceroberts]

Relates to #5985.
And implements: #6088

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

[pierceroberts]

@Dav1dde Please take a look at this implementation for the zip function. Thanks!
Also, Changelog failed again... This time I am pretty sure it's not the title, maybe it's the description?

[olksdr]

@pierceroberts you will have to fix the title, you can see the error

Error: PR title does not match Sentry conventions.
Please follow the Sentry commit message conventions: https://develop.sentry.dev/engineering-practices/commit-messages/

[pierceroberts]

@pierceroberts you will have to fix the title, you can see the error

Error: PR title does not match Sentry conventions.
Please follow the Sentry commit message conventions: https://develop.sentry.dev/engineering-practices/commit-messages/

Huh weird, that links to commit-message guidelines and only mentions the pr title once... I'll have to do some more digging to figure out what is wrong with the title.
Alright fixed the title, now looks like it's a changelog issue.

[pierceroberts]

@olksdr I fixed the failing pipeline. I did add the log to the unreleased section. Let me know if I need to move that. Thanks!

[pierceroberts]

MIght be a flaky test in the integration test suit:

FAILED tests/integration/test_metrics.py::test_transaction_metrics_extraction_external_relays[False] - AssertionError: assert 3 == 4
 +  where 3 = len({'discarded_events': [], 'filtered_sampling_events': [{'category': 'span_indexed', 'quantity': 2, 'reason': 'Sampled:0'}, {'category': 'transaction_indexed', 'quantity': 1, 'reason': 'Sampled:0'}], 'timestamp': 1783399550})
============ 1 failed, 966 passed, 59 skipped in 451.44s (0:07:31) =============
make: *** [Makefile:75: test-integration] Error 1
Error: Process completed with exit code 2.

If it passes, Should I create an issue for it?

[Dav1dde]

Can remove the changelog now, added the skip-changelog label

[pierceroberts]

Okay I did fix the pipeline. What is the standard here? So I can do it right next time.

[Dav1dde]

Rule of thumb, If it has customer observable impact -> Fix/Feature, if it has any visible impact -> Internal. If it is a non trivial refactor which should not have any impact -> Internal, everything else -> No Changelog.

[pierceroberts]

I went ahead and deleted this change log entry.

[Dav1dde]

This can be simplified to:

    Managed::zip(managed_err, items).try_map(|(_, items), _| {
        let event_id = common::event_id_from_items(&items)?.unwrap_or_default();
        let envelope = Envelope::from_request(Some(event_id), meta).with_items(items);
        Ok::<_, BadStoreRequest>(Box::new(envelope))
    })

Which then we might as well inline and we can drop the helper.

[pierceroberts]

By dropping the helper, are you referring to the map function? or zip?

[Dav1dde]

I meant the fn envelope helper function, with zip + try_map I feel like we can inline it without having to go through that function.

[pierceroberts]

Alright I made this change would you like me to create another issue to remove the envelope function? Or would you still like to noodle on it?

[pierceroberts]

Apologies, I was out on holiday and am getting ready to go back to work. I'll try to get working on this again.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 34504d8. Configure here.}

[pierceroberts]

@Dav1dde I am not sure what is up with the warden pipeline. But do these changes look good to you. Thanks!

[Dav1dde]

@pierceroberts ah sorry I missed the update on the PR, mind removing the fn envelope helper and just inlining the code? From what it looks like the envelope function is only called once and now a bit obsolete.

Warden is failing because of missing security tokens for external PRs, I reported that but fine to ignore.

[pierceroberts]

@Dav1dde No worries! Are you good if we merge this and create a new PR to remove the envelope fn or you'd prefer to use this same PR? I can start that this week.

[Dav1dde]

Sounds like you'd prefer to do it in a separate PR^^, let's get this merged.

[Dav1dde]

Interesting somehow a lint is failing now

error: unused import: `relay_event_schema::protocol::EventId`
  --> relay-server/src/endpoints/playstation.rs:10:5
   |
10 | use relay_event_schema::protocol::EventId;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `-D unused-imports` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_imports)]`