ci: gate reload deploy on GitHub Actions instead of Cloud Build#350
Merged
Conversation
Now that the production image is built and pushed by the image workflow (.github/workflows/image.yml), switch the GoCD checks stage from checks-googlecloud-check-cloudbuild to checks-githubactions-checkruns, waiting on the "Build and push production image" job. Remove cloudbuild.yaml since Cloud Build no longer builds this service. The deploy stage is unchanged: the image is still tagged with the full commit SHA at us-central1-docker.pkg.dev/sentryio/reload/image. Merge this only after the image workflow has been verified pushing images on master. After it lands, the Cloud Build trigger (build-reload-image) can be disabled. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The GitHub Actions builder cannot pull from sentryio/dhi (403 anonymous token); only the sentryio/dhi-mirror repo is readable. Switching the base images to dhi-mirror is what makes the GHA build succeed, so it lands atomically with the GoCD gate flip in this PR: once merged, the image workflow builds dhi-mirror (green) and GoCD gates on that run, while Cloud Build — which fails on dhi-mirror with "invalid tar header" — is no longer in the deploy path. Supersedes #348. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
oioki
force-pushed
the
alextarasov/reload-gocd-gha-checks
branch
from
June 15, 2026 22:56
3c72db3 to
9725e09
Compare
oioki
marked this pull request as ready for review
June 15, 2026 22:56
4 tasks
joshuarli
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Atomic cutover: move the reload image build off Cloud Build onto GitHub Actions.
Cloud Build can't unpack the
dhi-mirror(Docker Hardened Image) base layers (archive/tar: invalid tar header). The GHA builder, conversely, can't pull the oldsentryio/dhirepo (403). So the base-image switch and the deploy-gate switch are two sides of one change and must land together:sentryio/dhi-mirrorbases (supersedes chore: use dhi-mirror as base images #348). Makes the GHAimageworkflow build successfully.checksstage →checks-githubactions-checkruns getsentry/reload ${GO_REVISION_RELOAD_REPO} "Build and push production image"(matches the jobname:in.github/workflows/image.yml), plus theGITHUB_TOKENsecret env checkruns needs.cloudbuild.yaml— Cloud Build no longer builds this service.us-central1-docker.pkg.dev/sentryio/reload/image:${GO_REVISION_RELOAD_REPO}(full SHA, matching what the action tags).Verified on #349: on a dhi-mirror commit, the GHA workflow built and pushed
…/reload/image:<sha>and…/reload-mr/image:<sha>to both registries via thegha-gcr-pushWIF identity (getsentry/security-as-code#3128), while Cloud Build failed on the same commit.After merge: ask dev-infra to disable the
build-reload-imageCloud Build trigger (it will keep firing and failing on dhi-mirror until then, but is no longer in the deploy path).