repro(android): demonstrate R8 throwable class merging - #53
Draft
sentry-junior[bot] wants to merge 2 commits into
Draft
repro(android): demonstrate R8 throwable class merging#53sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: Roman Zavarnitsyn <roman.zavarnitsyn@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a minimal, customer-neutral Android project demonstrating that AGP 9.2.1 / R8 can merge two custom
RuntimeExceptionsubclasses into one residual runtime class.The generated mapping preserves the second exception's constructor as an inlined frame, while
Throwable#getClass().getName()observes only the surviving residual class. This reproduces the exception-type / constructor-frame mismatch relevant to crash reporting.Verification
:app:clean :app:assembleReleasepasses with JDK 17, Gradle 9.4.1, Android SDK 36, and AGP 9.2.1.DiagnosticTestException -> a;ExampleNonFatal.<init>appears as an inlined frame.-keep,allowshrinking,allowobfuscation class * extends java.lang.Throwable, the mapping contains distinct residual classes for both throwables.git diff --cached --checkpasses.Notes
No customer names, source code, event data, or Sentry credentials are included.
Requested by Roman Zavarnitsyn via Junior.
--
View Junior Session