fix: Fix spawn ENOENT for vite integration#1556
Conversation
|
This path is the same one that we use for https://github.com/getsentry/sentry-cli/blob/master/scripts/install.js script, so I'm not sure how that change would make a difference tbh. |
|
@kamilogorek You can find the exact usage here: https://github.com/n8n-io/n8n/pull/5870/files I had to patch the package in order to get it to work. Perhaps could have something to do with the fact that it's a monorepo? I'm not entirely sure, but it's worth looking into. |
| @@ -15,6 +15,7 @@ function getBinaryPath() { | |||
| const parts = []; | |||
There was a problem hiding this comment.
Could we use require.resolve instead here, like this:
path.join(require.resolve('@sentry/cli'), `../../bin/sentry-cli${process.platform === 'win32' ? '.exe' : ''}`)
Yes, that's most likely it, as it's making links between shared packages in the root directory. I'm out for the next few weeks, but will keep that issue in mind. |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Fixes vite plugin integration error.