feat(attributes): Deprecate cloudflare.d1.query_type#411
Merged
Conversation
JPeer264
requested review from
a team,
Lms24,
cleptric,
mjq and
nsdeschenes
as code owners
June 2, 2026 11:27
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Internal Changes 🔧Pii
Other
🤖 This preview updates automatically when you update the PR. |
cleptric
approved these changes
Jun 2, 2026
Lms24
approved these changes
Jun 2, 2026
JPeer264
force-pushed
the
jp/deprecate-d1-query-type
branch
from
June 15, 2026 08:37
63e6c39 to
52be7cd
Compare
JPeer264
enabled auto-merge (squash)
June 15, 2026 08:38
4 tasks
JPeer264
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Jun 24, 2026
…#21292) This PR does 2 things: 1. It adds missing methods of D1 and adds a span to each - `batch`, `exec`, and `withSession`. `withSession` is not doing anything as per spec, but instruments its return values `prepare` and `batch` 2. Some Sentry convention updates - it changes `cloudflare.d1.query_type` to `db.operation.name` and is therefore dependent on getsentry/sentry-conventions#411 - it also uses `db.operation.batch.size`: getsentry/sentry-conventions#407 --- AI generated text: Instrument `db.batch()`, `db.exec()`, and `db.withSession()` methods that were previously not covered by D1 instrumentation. --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I went over the Cloudflare D1 instrumentation and saw
cloudflare.d1.query_type. Since the query type is the same as thedb.operation.nameit would be better to use this one (it would also be aligned with workerd itself)A PR will follow in the SDK to update the field
PR Checklist
yarn testand verified that the tests pass.yarn generateto generate and format code and docs.If an attribute was added:
nextjs.function_id, notfunction_id)pii(i.e.maybeortrue. Usefalseonly for values that should never be scrubbed such as IDs)If an attribute was deprecated: