Skip to content

fix(attributes): Set pii: 'maybe' on faas string attributes #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 6 commits into from
Jun 5, 2026
Merged

fix(attributes): Set pii: 'maybe' on faas string attributes #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d08c554
fix(attributes): Set `pii: 'maybe'` on `faas` string attribute
Lms24 Jun 5, 2026
8dcf4da
pr number
Lms24 Jun 5, 2026
5856ad5
generate
Lms24 Jun 5, 2026
9d65548
default to `'maybe'` in create attribute CLI script
Lms24 Jun 5, 2026
be96460
entry point
Lms24 Jun 5, 2026
abda68e
regenerate
Lms24 Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions javascript/sentry-conventions/src/attributes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4712,7 +4712,7 @@ export type FAAS_DURATION_IN_MS_TYPE = number;
*
* Attribute Value Type: `string` {@link FAAS_ENTRY_POINT_TYPE}
*
* Contains PII: false
* Contains PII: maybe
*
* Attribute defined in OTEL: No
* Visibility: public
Expand Down Expand Up @@ -4754,7 +4754,7 @@ export type FAAS_IDENTITY_TYPE = string;
*
* Attribute Value Type: `string` {@link FAAS_NAME_TYPE}
*
* Contains PII: false
* Contains PII: maybe
*
* Attribute defined in OTEL: Yes
* Visibility: public
Expand Down Expand Up @@ -18227,7 +18227,7 @@ export const ATTRIBUTE_METADATA: Record<AttributeName, AttributeMetadata> = {
brief: "The code that's run when the cloud provider invokes your function.",
type: 'string',
pii: {
isPii: 'false',
isPii: 'maybe',
},
isInOtel: false,
visibility: 'public',
Expand All @@ -18251,12 +18251,12 @@ export const ATTRIBUTE_METADATA: Record<AttributeName, AttributeMetadata> = {
brief: 'The name of the serverless function',
type: 'string',
pii: {
isPii: 'false',
isPii: 'maybe',
},
isInOtel: true,
visibility: 'public',
example: 'my_function',
changelog: [{ version: 'next' }],
changelog: [{ version: 'next', prs: [403, 415] }],
},
[FAAS_TIME]: {
brief: 'A string containing the function invocation time in the ISO 8601 format expressed in UTC.',
Expand Down
2 changes: 1 addition & 1 deletion model/attributes/faas/faas__entry_point.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"brief": "The code that's run when the cloud provider invokes your function.",
"type": "string",
"pii": {
"key": "false"
"key": "maybe"
},
"is_in_otel": false,
"example": "my_main_function",
Expand Down
5 changes: 3 additions & 2 deletions model/attributes/faas/faas__name.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,15 @@
"brief": "The name of the serverless function",
"type": "string",
"pii": {
"key": "false"
"key": "maybe"
},
"is_in_otel": true,
"example": "my_function",
"visibility": "public",
"changelog": [
{
"version": "next"
"version": "next",
"prs": [403, 415]
}
]
}
10 changes: 5 additions & 5 deletions python/src/sentry_conventions/attributes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2893,7 +2893,7 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
"""The code that's run when the cloud provider invokes your function.

Type: str
Contains PII: false
Contains PII: maybe
Defined in OTEL: No
Visibility: public
Example: "my_main_function"
Expand All @@ -2915,7 +2915,7 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
"""The name of the serverless function

Type: str
Contains PII: false
Contains PII: maybe
Defined in OTEL: Yes
Visibility: public
Example: "my_function"
Expand Down Expand Up @@ -11333,7 +11333,7 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
"faas.entry_point": AttributeMetadata(
brief="The code that's run when the cloud provider invokes your function.",
type=AttributeType.STRING,
pii=PiiInfo(isPii=IsPii.FALSE),
pii=PiiInfo(isPii=IsPii.MAYBE),
is_in_otel=False,
visibility=Visibility.PUBLIC,
example="my_main_function",
Expand All @@ -11355,12 +11355,12 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
"faas.name": AttributeMetadata(
brief="The name of the serverless function",
type=AttributeType.STRING,
pii=PiiInfo(isPii=IsPii.FALSE),
pii=PiiInfo(isPii=IsPii.MAYBE),
is_in_otel=True,
visibility=Visibility.PUBLIC,
example="my_function",
changelog=[
ChangelogEntry(version="next"),
ChangelogEntry(version="next", prs=[403, 415]),
],
),
"faas.time": AttributeMetadata(
Expand Down
3 changes: 2 additions & 1 deletion scripts/create_attribute.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,10 +273,11 @@ async function askForAttributePii() {
select({
message: 'Does the attribute contain PII?',
options: [
{ value: 'maybe', label: 'Maybe' },
{ value: 'true', label: 'Yes' },
{ value: 'false', label: 'No' },
{ value: 'maybe', label: 'Maybe' },
],
initialValue: 'maybe',
}),
);
}
Expand Down
Loading