chore: Update logo for dark or light theme#854
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #854 +/- ##
=======================================
Coverage 90.29% 90.29%
=======================================
Files 119 119
Lines 3762 3762
=======================================
Hits 3397 3397
Misses 365 365 Continue to review full report at Codecov.
|
brustolin
approved these changes
May 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update logo to use media queries so it looks good on both dark and light themes.
See getsentry/sentry#34229 for screenshot of effect, or view readme on this branch after changing your theme.
In this particular repo, there's another image for the "Flutter Favorite" next to the Sentry logo. Unfortunately, I can't seem to get it to render side-by-side with the Sentry logo as it was before. Best I can do is align it to the right side of the text. Otherwise it renders below the Sentry logo and takes too much space. Open to suggestions there.
#skip-changelog