Add Feedbacks page under Telemetry - #13310
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
stefanosiano
commented
Apr 9, 2025
stefanosiano
commented
Apr 9, 2025
stefanosiano
commented
Apr 9, 2025
stefanosiano
changed the title
coolguyzone
reviewed
Apr 11, 2025
aliu39
reviewed
Apr 13, 2025
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io> Co-authored-by: Andrew Liu <159852527+aliu39@users.noreply.github.com>
Co-authored-by: Andrew Liu <159852527+aliu39@users.noreply.github.com>
… into stefanosiano/feedback-telemetry
specified SDK doesn't have to fill name and email with user context, as it's done by backend updated scope data to apply to feedbacks
aliu39
approved these changes
Apr 14, 2025
Co-authored-by: Andrew Liu <159852527+aliu39@users.noreply.github.com>
romtsn
reviewed
Apr 16, 2025
| ## Full Envelope Example | ||
|
|
||
| ```json | ||
| {"event_id":"9ec79c33ec9942ab8353589fcb2e04dc","sent_at":"2024-03-19T15:18:27.581Z","sdk":{"name":"sentry.javascript.react","version":"7.105.0"}} |
Member
Member
There was a problem hiding this comment.
@bruno-garcia suggested we should include it -
it's important as I don't think we'll link the feedback to other data properly without it.
bitsandfoxes
pushed a commit
that referenced
this pull request
Apr 24, 2025
* Added Feedbacks page under Telemetry with SDK processing details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Added Feedbacks page under Telemetry with SDK processing details.
This will help SDKs to align on the expected feedback processing.
Closes getsentry/sentry#88232
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: