Skip to content

ref(css): Shrink h4 to differentiate it from h3 #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lobsterkatie merged 1 commit into from
May 11, 2020
Merged

ref(css): Shrink h4 to differentiate it from h3 #1675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/_assets/css/_includes/bootstrap-overrides.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ $small-font-size: 85%;
$h1-font-size: 2em;
$h2-font-size: 1.5em;
$h3-font-size: 1.125em;
$h4-font-size: 1.075em;
$h4-font-size: 1em;
Copy link
Copy Markdown
Contributor

@rhcarvalho rhcarvalho May 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but I can't fail but notice that now h4, h5 and h6 are all the same size :)

And we do have cases in the docs that we use as many as 5 nesting levels :/

Might be the time to loop in a designer and review the header styles. (Or stop nesting so many levels in a single page, which is also humanly hard to follow/distinguish)

Copy link
Copy Markdown
Contributor

@PeloWriter PeloWriter May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good point, Rodolfo, thank you. My preference is that we do not ever use an H5 or H6. Doing so is, as you note, not super helpful to readers because they're those headers are visually so close. In reality, the need for this level heading suggests there's actually a deeper content problem - we shouldn't need more than four headings.

$h5-font-size: 1em;
$h6-font-size: 1em;

Expand Down