docs(apple): Add missing experimental options and remove experimental-features page#17987
Open
philprime wants to merge 2 commits into
Open
docs(apple): Add missing experimental options and remove experimental-features page#17987philprime wants to merge 2 commits into
philprime wants to merge 2 commits into
Conversation
…-features page Add SdkOption entries for experimental.enableUnhandledCPPExceptionsV2 and experimental.enableWatchdogTerminationsV2 to the options reference. Remove the standalone experimental-features page since all its content is now covered in options.mdx or linked target pages. Remove references from features index pages for common, macOS, and visionOS.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| @@ -83,10 +83,6 @@ All features listed below are **enabled by default** unless otherwise noted. Som | |||
| - Offline caching when a device is unable to connect; we send a report once we receive another event | |||
| - Event persistence: crash reports persist to disk and are sent upon application start if not sent immediately after a crash | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Bug: The static file public/_platforms/apple/ios.json is not regenerated and contains stale references to the deleted experimental-features page, which may cause issues for consuming systems.
Severity: LOW
Suggested Fix
Manually update the public/_platforms/apple/ios.json file to remove all references to the deleted experimental-features page. Alternatively, confirm with the relevant team whether this file is still in use. If it is deprecated, consider removing it entirely.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: docs/platforms/apple/common/features/index.mdx#L85
Potential issue: The build process does not automatically regenerate the
`public/_platforms/apple/ios.json` file. This static, checked-in file contains stale
references and HTML content related to a now-deleted `experimental-features` page.
According to documentation, this file may be consumed by an external utility in the main
Sentry repository. If that utility is still in use and attempts to process the stale
links from this JSON, it could lead to broken links or other failures in the integration
documentation system.
Also affects:
docs/platforms/apple/guides/macos/features/index.mdx:92~92docs/platforms/apple/guides/visionos/features/index.mdx:71~71
Did we get this right? 👍 / 👎 to inform future reviews.
…s.json The static _platforms/apple/ios.json still contained the old experimental features content that was removed from the live docs in 6e63335. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Add missing
<SdkOption>entries forexperimental.enableUnhandledCPPExceptionsV2andexperimental.enableWatchdogTerminationsV2to the Apple SDK options reference.Remove the standalone
experimental-features.mdxpage since all its content is now covered inoptions.mdxor on the pages it linked to (some of which were broken links to features removed in SDK 9.0.0).experimental.enableUnhandledCPPExceptionsV2option tooptions.mdxexperimental.enableWatchdogTerminationsV2option tooptions.mdxdocs/platforms/apple/common/features/experimental-features.mdxIS YOUR CHANGE URGENT?
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST