Skip to content

fix(develop): Clarify add_feature_flag API value type requirements#18281

Merged
Lms24 merged 3 commits into
masterfrom
lms/fix-develop-ff-allowed-types
Jun 5, 2026
Merged

fix(develop): Clarify add_feature_flag API value type requirements#18281
Lms24 merged 3 commits into
masterfrom
lms/fix-develop-ff-allowed-types

Conversation

@Lms24
Copy link
Copy Markdown
Member

@Lms24 Lms24 commented Jun 5, 2026

DESCRIBE YOUR PR

Update the add_feature_flag API documentation to specify that only boolean values are accepted.

Looks like the initial spec was too broad, as our product currently only supports boolean feature flags.
This was raised in getsentry/sentry-javascript#21157.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Updated the `add_feature_flag` API documentation to specify that only boolean values are accepted.

Looks like the initial spec was too broad, as our product currently only supports boolean feature flags.
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
develop-docs Ready Ready Preview, Comment Jun 5, 2026 4:21pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
sentry-docs Ignored Ignored Preview Jun 5, 2026 4:21pm

Request Review

@github-actions github-actions Bot added the sdk-develop-docs PRs touching develop-docs/sdk label Jun 5, 2026
Comment thread develop-docs/sdk/foundations/client/integrations/feature-flags.mdx Outdated
Comment thread develop-docs/sdk/foundations/client/integrations/feature-flags.mdx
Comment thread develop-docs/sdk/foundations/client/integrations/feature-flags.mdx Outdated
@Lms24 Lms24 enabled auto-merge (squash) June 5, 2026 16:14
@Lms24 Lms24 merged commit 0ea75e1 into master Jun 5, 2026
21 checks passed
@Lms24 Lms24 deleted the lms/fix-develop-ff-allowed-types branch June 5, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sdk-develop-docs PRs touching develop-docs/sdk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants