Revert "feat(homepage): Bifurcated homepage refresh" - #18870
Conversation
This reverts commit e368094.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit afde0dd. Configure here.
| ,{' '} | ||
| <Link href="/product/drains/" className="text-[#8b5cf6] underline"> | ||
| Logs | ||
| </Link> |
There was a problem hiding this comment.
Wrong Logs product link
Medium Severity
The homepage feature list labels this link as Logs, but href points to /product/drains/ (Log and Trace Drains) instead of /product/logs/. Visitors expecting Logs docs land on a different product page.
Reviewed by Cursor Bugbot for commit afde0dd. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| <div className="w-full relative hero-gradient"> | ||
| {/* Single decorative squiggle at top right */} | ||
| <img | ||
| src={SquiggleSVG.src} |
There was a problem hiding this comment.
Bug: The code accesses SquiggleSVG.src directly. If the SVG is imported as a string URL instead of an object, .src will be undefined, causing a broken image.
Severity: LOW
Suggested Fix
To prevent a broken image, update the img tag to handle cases where the SVG is imported as a string. Use a defensive check like src={typeof SquiggleSVG === 'string' ? SquiggleSVG : SquiggleSVG?.src} to ensure the image source is always a valid string.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: src/components/home.tsx#L67
Potential issue: The `img` tag at `src/components/home.tsx:67` uses `SquiggleSVG.src` as
its source. This assumes the `SquiggleSVG` import is an object with a `.src` property.
However, depending on the Next.js configuration, SVG imports can resolve to a simple
string URL. In that scenario, attempting to access the `.src` property of a string
results in `undefined`, which will cause the image to fail to load. The codebase already
contains a safer pattern for this in `platformIcon.tsx`, which handles both string and
object imports: `typeof svg === 'string' ? svg : svg?.src`.
Also affects:
src/components/home.tsx:17~17
Did we get this right? 👍 / 👎 to inform future reviews.
2 participants
Reverts #18786