Skip to content

feat(react): Document error boundary linked error#7735

Merged
AbhiPrasad merged 2 commits into
masterfrom
abhi-errorboundary-linked-errors
Sep 6, 2023
Merged

feat(react): Document error boundary linked error#7735
AbhiPrasad merged 2 commits into
masterfrom
abhi-errorboundary-linked-errors

Conversation

@AbhiPrasad
Copy link
Copy Markdown
Contributor

@AbhiPrasad AbhiPrasad commented Sep 5, 2023

I merged getsentry/sentry-javascript#3532 around 2+ years ago at this point, but never got around to documenting it. Making up for my mistake now (also because someone asked).

image

@AbhiPrasad AbhiPrasad requested review from a team, Lms24, mydea and shanamatthews and removed request for a team September 5, 2023 18:06
@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 0:02am


</Alert>

## Linked Errors
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: iirc there's something special about the parent/child relationship here. Should we mention this?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found what I had in mind: getsentry/sentry-javascript#8871

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah good point I'll write that down.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not gonna go into detail, instead just document what the current behaviour is.

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) September 6, 2023 11:54
@AbhiPrasad AbhiPrasad merged commit 9c96cef into master Sep 6, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-errorboundary-linked-errors branch September 6, 2023 12:07
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants