Skip to content

docs: fix XML comments for boolean return of ILogEntryFilter - #5311

Merged
jamescrosswell merged 1 commit into
mainfrom
docs/extensions-logging-filters-fix
Jun 24, 2026
Merged

docs: fix XML comments for boolean return of ILogEntryFilter#5311
jamescrosswell merged 1 commit into
mainfrom
docs/extensions-logging-filters-fix

Conversation

@Flash0ver

@Flash0ver Flash0ver commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix XML comments for bool return of ILogEntryFilter.

Remarks

Follow-up to #5297, where we did fix the grammar of one comment during review, but missed the 2nd comment.
See suggestion applied via #5297 (comment).


#skip-changelog, due to follow-up to still Unreleased changes of #5297

@Flash0ver Flash0ver self-assigned this Jun 24, 2026
@Flash0ver Flash0ver added the skip-changelog Suppress automatic changelog generation via Craft label Jun 24, 2026
Comment thread src/Sentry.Extensions.Logging/SentryLoggingOptionsExtensions.cs
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.16%. Comparing base (334bcdf) to head (b1d9f24).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5311      +/-   ##
==========================================
- Coverage   74.17%   74.16%   -0.02%     
==========================================
  Files         508      508              
  Lines       18353    18353              
  Branches     3586     3586              
==========================================
- Hits        13614    13612       -2     
- Misses       3867     3869       +2     
  Partials      872      872              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Flash0ver
Flash0ver marked this pull request as ready for review June 24, 2026 13:41
@jamescrosswell
jamescrosswell merged commit 6620fac into main Jun 24, 2026
48 checks passed
@jamescrosswell
jamescrosswell deleted the docs/extensions-logging-filters-fix branch June 24, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Suppress automatic changelog generation via Craft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants