Skip to content

Set tags on SentryOptions through external configuration#1066

Merged
maciejwalkowiak merged 4 commits into
mainfrom
gh-981
Nov 26, 2020
Merged

Set tags on SentryOptions through external configuration#1066
maciejwalkowiak merged 4 commits into
mainfrom
gh-981

Conversation

@maciejwalkowiak

@maciejwalkowiak maciejwalkowiak commented Nov 24, 2020

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Add an option to set tags on SentryOptions through external configuration.

💡 Motivation and Context

Fixes gh-981. Agreed with @bruno-garcia to add tags to SentryOptions.

💚 How did you test it?

Unit & integration tests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

Comment thread sentry/src/main/java/io/sentry/MainEventProcessor.java Outdated
Comment thread sentry/src/main/java/io/sentry/MainEventProcessor.java
Comment thread sentry/src/main/java/io/sentry/SentryOptions.java Outdated
Comment thread sentry/src/main/java/io/sentry/SentryOptions.java Outdated
Comment thread sentry/src/main/java/io/sentry/SentryOptions.java Outdated
Comment thread sentry/src/main/java/io/sentry/SentryOptions.java
Comment thread sentry/src/main/java/io/sentry/config/AbstractPropertiesProvider.java Outdated
Comment thread sentry/src/main/java/io/sentry/config/CompositePropertiesProvider.java Outdated
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1066 (daa4d53) into main (c327574) will increase coverage by 0.30%.
The diff coverage is 98.07%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1066      +/-   ##
============================================
+ Coverage     72.95%   73.25%   +0.30%     
- Complexity     1520     1541      +21     
============================================
  Files           161      162       +1     
  Lines          5461     5508      +47     
  Branches        550      560      +10     
============================================
+ Hits           3984     4035      +51     
+ Misses         1187     1184       -3     
+ Partials        290      289       -1     
Impacted Files Coverage Δ Complexity Δ
...main/java/io/sentry/config/PropertiesProvider.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...a/io/sentry/config/AbstractPropertiesProvider.java 94.11% <94.11%> (ø) 6.00 <6.00> (?)
...ry/src/main/java/io/sentry/MainEventProcessor.java 78.18% <100.00%> (+1.71%) 17.00 <0.00> (+2.00)
sentry/src/main/java/io/sentry/SentryOptions.java 81.88% <100.00%> (+1.31%) 102.00 <2.00> (+5.00)
.../io/sentry/config/CompositePropertiesProvider.java 100.00% <100.00%> (ø) 7.00 <3.00> (+3.00)
.../config/EnvironmentVariablePropertiesProvider.java 100.00% <100.00%> (ø) 6.00 <4.00> (+4.00)
...ava/io/sentry/config/SimplePropertiesProvider.java 100.00% <100.00%> (ø) 1.00 <1.00> (-1.00)
...entry/config/SystemPropertyPropertiesProvider.java 100.00% <100.00%> (ø) 1.00 <1.00> (-1.00)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c327574...daa4d53. Read the comment docs.

@marandaneto marandaneto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciejwalkowiak maciejwalkowiak merged commit bb58d45 into main Nov 26, 2020
@maciejwalkowiak maciejwalkowiak deleted the gh-981 branch November 26, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SENTRY_TAGS environment variable doesn't work after upgrading from 1.7.30 to 3.0.0

3 participants