Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .craft.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ statusProvider:
artifactProvider:
name: github
targets:
- name: bintray
- name: github
- name: registry
type: sdk
Expand All @@ -34,6 +33,14 @@ targets:
type: sdk
config:
canonical: "maven:io.sentry:sentry-log4j2"
- name: registry
type: sdk
config:
canonical: "maven:io.sentry:sentry-jul"
- name: registry
type: sdk
config:
canonical: "maven:io.sentry:sentry-apache-http-client-5"
- name: registry
type: sdk
config:
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
* Enchancement: Support @SentrySpan and @SentryTransaction on classes and interfaces. (#1243)
* Enchancement: Do not serialize empty collections and maps (#1245)
* Ref: Simplify RestTemplate instrumentation (#1246)
* Ref: Prefix sdk.package names with io.sentry (#1249)
* Fix: Make the ANR Atomic flags immutable
* Enchancement: Integration interface better compatibility with Kotlin null-safety

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public SentryAndroidOptions() {
final String version = BuildConfig.VERSION_NAME;
sdkVersion = SdkVersion.updateSdkVersion(sdkVersion, name, version);

sdkVersion.addPackage("maven:sentry-android-core", version);
sdkVersion.addPackage("maven:io.sentry:sentry-android-core", version);

return sdkVersion;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ class SentryAndroidOptionsTest {
assertEquals(BuildConfig.VERSION_NAME, sdkVersion.version)

assertTrue(sdkVersion.packages!!.any {
it.name == "maven:sentry-android-core" &&
it.name == "maven:io.sentry:sentry-android-core" &&
it.version == BuildConfig.VERSION_NAME
})

assertTrue(sdkVersion.packages!!.any {
it.name == "maven:sentry" &&
it.name == "maven:io.sentry:sentry" &&
it.version == BuildConfig.VERSION_NAME
})
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ static void addPackage(@Nullable final SdkVersion sdkVersion) {
if (sdkVersion == null) {
return;
}
sdkVersion.addPackage("maven:sentry-android-ndk", BuildConfig.VERSION_NAME);
sdkVersion.addPackage("maven:io.sentry:sentry-android-ndk", BuildConfig.VERSION_NAME);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class SentryNdkUtilTest {
val options = SentryOptions()
SentryNdkUtil.addPackage(options.sdkVersion)
assertTrue(options.sdkVersion!!.packages!!.any {
it.name == "maven:sentry-android-ndk"
it.name == "maven:io.sentry:sentry-android-ndk"
it.version == BuildConfig.VERSION_NAME
})
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,6 @@ class SentryTimberIntegration(
}

private fun addPackage(sdkVersion: SdkVersion?) {
sdkVersion?.addPackage("maven:sentry-android-timber", BuildConfig.VERSION_NAME)
sdkVersion?.addPackage("maven:io.sentry:sentry-android-timber", BuildConfig.VERSION_NAME)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class SentryTimberIntegrationTest {
sut.register(fixture.hub, fixture.options)

assertTrue(fixture.options.sdkVersion!!.packages!!.any {
it.name == "maven:sentry-android-timber"
it.name == "maven:io.sentry:sentry-android-timber"
it.version == BuildConfig.VERSION_NAME
})
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ public void close() throws SecurityException {
final String version = BuildConfig.VERSION_NAME;

sdkVersion = SdkVersion.updateSdkVersion(sdkVersion, name, version);
sdkVersion.addPackage("maven:sentry-jul", version);
sdkVersion.addPackage("maven:io.sentry:sentry-jul", version);

return sdkVersion;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ class SentryHandlerTest {
assertEquals(BuildConfig.VERSION_NAME, it.version)
assertNotNull(it.packages)
assertTrue(it.packages!!.any { pkg ->
"maven:sentry-jul" == pkg.name &&
"maven:io.sentry:sentry-jul" == pkg.name &&
BuildConfig.VERSION_NAME == pkg.version
})
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ public void append(final @NotNull LogEvent eventObject) {
final String version = BuildConfig.VERSION_NAME;
sdkVersion = SdkVersion.updateSdkVersion(sdkVersion, name, version);

sdkVersion.addPackage("maven:sentry-log4j2", version);
sdkVersion.addPackage("maven:io.sentry:sentry-log4j2", version);

return sdkVersion;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ class SentryAppenderTest {
assertEquals(BuildConfig.VERSION_NAME, it.version)
assertNotNull(it.packages)
assertTrue(it.packages!!.any { pkg ->
"maven:sentry-log4j2" == pkg.name &&
"maven:io.sentry:sentry-log4j2" == pkg.name &&
BuildConfig.VERSION_NAME == pkg.version
})
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ protected void append(@NotNull ILoggingEvent eventObject) {
final String version = BuildConfig.VERSION_NAME;
sdkVersion = SdkVersion.updateSdkVersion(sdkVersion, name, version);

sdkVersion.addPackage("maven:sentry-logback", version);
sdkVersion.addPackage("maven:io.sentry:sentry-logback", version);

return sdkVersion;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ class SentryAppenderTest {
assertEquals(BuildConfig.VERSION_NAME, it.version)
assertNotNull(it.packages)
assertTrue(it.packages!!.any { pkg ->
"maven:sentry-logback" == pkg.name &&
"maven:io.sentry:sentry-logback" == pkg.name &&
BuildConfig.VERSION_NAME == pkg.version
})
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ static class ApacheHttpClientTransportFactoryAutoconfiguration {
final String version = BuildConfig.VERSION_NAME;
sdkVersion = SdkVersion.updateSdkVersion(sdkVersion, name, version);

sdkVersion.addPackage("maven:sentry-spring-boot-starter", version);
sdkVersion.addPackage("maven:io.sentry:sentry-spring-boot-starter", version);

return sdkVersion;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ class SentryAutoConfigurationTest {
assertThat(sdk.version).isEqualTo(BuildConfig.VERSION_NAME)
assertThat(sdk.name).isEqualTo(BuildConfig.SENTRY_SPRING_BOOT_SDK_NAME)
assertThat(sdk.packages).anyMatch { pkg ->
pkg.name == "maven:sentry-spring-boot-starter" && pkg.version == BuildConfig.VERSION_NAME
pkg.name == "maven:io.sentry:sentry-spring-boot-starter" && pkg.version == BuildConfig.VERSION_NAME
}
}, anyOrNull())
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ private void registerSentryExceptionResolver(
final String version = BuildConfig.VERSION_NAME;
sdkVersion = SdkVersion.updateSdkVersion(sdkVersion, name, version);

sdkVersion.addPackage("maven:sentry-spring", version);
sdkVersion.addPackage("maven:io.sentry:sentry-spring", version);

return sdkVersion;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class EnableSentryTest {
assertThat(options.sdkVersion!!.name).isEqualTo("sentry.java.spring")
assertThat(options.sdkVersion!!.version).isEqualTo(BuildConfig.VERSION_NAME)
assertThat(options.sdkVersion!!.packages).isNotNull
assertThat(options.sdkVersion!!.packages!!.map { pkg -> pkg.name }).contains("maven:sentry-spring")
assertThat(options.sdkVersion!!.packages!!.map { pkg -> pkg.name }).contains("maven:io.sentry:sentry-spring")
}
}

Expand Down
2 changes: 1 addition & 1 deletion sentry/src/main/java/io/sentry/SentryOptions.java
Original file line number Diff line number Diff line change
Expand Up @@ -1329,7 +1329,7 @@ void merge(final @NotNull SentryOptions options) {
final SdkVersion sdkVersion = new SdkVersion(BuildConfig.SENTRY_JAVA_SDK_NAME, version);

sdkVersion.setVersion(version);
sdkVersion.addPackage("maven:sentry", version);
sdkVersion.addPackage("maven:io.sentry:sentry", version);

return sdkVersion;
}
Expand Down
2 changes: 1 addition & 1 deletion sentry/src/test/java/io/sentry/GsonSerializerTest.kt
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ class GsonSerializerTest {
assertNotNull(sdkInfo.packages)

assertTrue(sdkInfo.packages!!.any {
it.name == "maven:sentry-android-core"
it.name == "maven:io.sentry:sentry-android-core"
it.version == "4.5.6"
})
}
Expand Down
2 changes: 1 addition & 1 deletion sentry/src/test/java/io/sentry/SentryOptionsTest.kt
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ class SentryOptionsTest {
assertEquals(BuildConfig.VERSION_NAME, sdkVersion.version)

assertTrue(sdkVersion.packages!!.any {
it.name == "maven:sentry" &&
it.name == "maven:io.sentry:sentry" &&
it.version == BuildConfig.VERSION_NAME
})
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{"sdk":{"name":"test","version":"1.2.3","integrations":["NdkIntegration"],"packages":[{"name":"maven:sentry-android-core","version":"4.5.6"}]}}
{"sdk":{"name":"test","version":"1.2.3","integrations":["NdkIntegration"],"packages":[{"name":"io.sentry:maven:sentry-android-core","version":"4.5.6"}]}}
{"content_type":"application/json","type":"session","length":306}
{"sid":"c81d4e2e-bcf2-11e6-869b-7df92533d2db","did":"123","init":true,"started":"2020-02-07T14:16:00Z","status":"ok","seq":123456,"errors":2,"duration":6000.0,"timestamp":"2020-02-07T14:16:00Z","attrs":{"release":"io.sentry@1.0+123","environment":"debug","ip_address":"127.0.0.1","user_agent":"jamesBond"}}