You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
rules are per module, so some of them need to be placed in all of our android modules.
missing 2 important rules that keep our stack traces unambiguous
Seeing @maciejwalkowiak tagged here made me realize you probably want to tune the CODEOWNERS so the Android part is owned by manoel and the java part by maciej
Seeing @maciejwalkowiak tagged here made me realize you probably want to tune the CODEOWNERS so the Android part is owned by manoel and the java part by maciej
Seeing @maciejwalkowiak tagged here made me realize you probably want to tune the CODEOWNERS so the Android part is owned by manoel and the java part by maciej
not sure, whos gonna review our own PRs then? :)
You can assign ppl for review when needed. If you need me or Philipp to review tag us.
It's just too painful to get tagged on literally all PRs automatically
Seeing @maciejwalkowiak tagged here made me realize you probably want to tune the CODEOWNERS so the Android part is owned by manoel and the java part by maciej
not sure, whos gonna review our own PRs then? :)
You can assign ppl for review when needed. If you need me or Philipp to review tag us.
It's just too painful to get tagged on literally all PRs automatically
are we talking about the mobile team or @maciejwalkowiak being tagged on an Android PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix: Add missing proguard rules
💡 Motivation and Context
rules are per module, so some of them need to be placed in all of our android modules.
missing 2 important rules that keep our stack traces unambiguous
💚 How did you test it?
📝 Checklist
🔮 Next steps