Skip to content

Feat: Add "data" to spans#1717

Merged
maciejwalkowiak merged 6 commits into
mainfrom
gh-1233
Sep 15, 2021
Merged

Feat: Add "data" to spans#1717
maciejwalkowiak merged 6 commits into
mainfrom
gh-1233

Conversation

@maciejwalkowiak

@maciejwalkowiak maciejwalkowiak commented Sep 15, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

📜 Description

Add "data" to spans.

💡 Motivation and Context

Fixes #1233

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review September 15, 2021 08:41
marandaneto
marandaneto reviewed Sep 15, 2021
View reviewed changes
Comment thread sentry/src/main/java/io/sentry/ISpan.java Outdated
marandaneto
marandaneto reviewed Sep 15, 2021
View reviewed changes
Comment thread sentry/src/test/java/io/sentry/SentryTracerTest.kt Outdated
marandaneto
marandaneto reviewed Sep 15, 2021
View reviewed changes
Comment thread sentry/src/test/java/io/sentry/SentryTracerTest.kt Outdated
maciejwalkowiak and others added 4 commits September 15, 2021 11:27
@maciejwalkowiak @marandaneto
Update sentry/src/test/java/io/sentry/SentryTracerTest.kt
db13534 
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
@maciejwalkowiak @marandaneto
Update sentry/src/test/java/io/sentry/SentryTracerTest.kt
b513a31 
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
@maciejwalkowiak @marandaneto
Update sentry/src/main/java/io/sentry/ISpan.java
1d5ce6e 
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
@maciejwalkowiak
Merge branch 'main' into gh-1233
c0f47d3
@maciejwalkowiak

maciejwalkowiak commented Sep 15, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for polishing @marandaneto

@maciejwalkowiak maciejwalkowiak merged commit 28ed730 into main Sep 15, 2021
@maciejwalkowiak maciejwalkowiak deleted the gh-1233 branch September 15, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia
1 more reviewer
@marandaneto marandaneto marandaneto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Span.data is missing

2 participants

@maciejwalkowiak @marandaneto