Attachments can be manipulated via hints - Extra for attachment methods directly on Hints#2049
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Attachments can be manipulated via hints - Extra for attachment methods directly on Hints ([#2049](https://github.com/getsentry/sentry-java/pull/2049))If none of the above apply, you can opt out of this check by adding |
Codecov Report
@@ Coverage Diff @@
## feat/allow-attachment-manipulation-via-hints #2049 +/- ##
===============================================================================
Coverage ? 80.96%
Complexity ? 3177
===============================================================================
Files ? 229
Lines ? 11707
Branches ? 1556
===============================================================================
Hits ? 9479
Misses ? 1646
Partials ? 582 Continue to review full report at Codecov.
|
bruno-garcia
left a comment
There was a problem hiding this comment.
having a List<> instead of relying on the Map<String, Object> is ideal.
Other than that, LGTM
| } | ||
|
|
||
| public void clearAttachments() { | ||
| internalStorage.put(SENTRY_ATTACHMENTS, new CopyOnWriteArrayList<Attachment>()); |
There was a problem hiding this comment.
this could be a list instead
|
Decided to go with list property in |
📜 Description
Extra for #2046 with attachment methods directly in
Hintsinstead of a separateAttachmentsobject.💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps