"mod.require is not a function" Error after upgrading from 5.23.0 to >=5.24.0

[sergio-dreamcode]

• Review the documentation: https://docs.sentry.io/
• Search for existing issues: https://github.com/getsentry/sentry-javascript/issues
• Use the latest release: https://github.com/getsentry/sentry-javascript/releases
• Provide a link to the affected event from your Sentry account

Package + Version

• @sentry/browser
• @sentry/node
• raven-js
• raven-node (raven for node)
• other:

Version:

>=5.24.0

Description

Hello, we use Sentry for our Serverless applications which use NestJS and the nest-raven library that implements an interceptor to catch the errors and report them to Sentry.io and everything is bundled using Webpack. After we upgraded from 5.23.0 to the last version 5.26.0 we noticed that when an exception happens we receive an Internal Server Error and the original Exception is not reported to Sentry.io because it is the Sentry library that is having problems. The backend logs we have are:

  | 2020-10-13T14:51:20.131-04:00 | TypeError: mod.require is not a function
-- | -- | --
  | 2020-10-13T14:51:20.131-04:00 | at dynamicRequire (/var/task/src/adapters/graphql/handler.js:79802:16)
  | 2020-10-13T14:51:20.131-04:00 | at /var/task/src/adapters/graphql/handler.js:79860:39
  | 2020-10-13T14:51:20.131-04:00 | at Array.forEach (<anonymous>)
  | 2020-10-13T14:51:20.131-04:00 | at extractNodeRequestData (/var/task/src/adapters/graphql/handler.js:79845:10)
  | 2020-10-13T14:51:20.131-04:00 | at Module.parseRequest (/var/task/src/adapters/graphql/handler.js:131937:61)
  | 2020-10-13T14:51:20.131-04:00 | at RavenInterceptor.captureGraphQLException (/var/task/src/adapters/graphql/handler.js:645524:42)
  | 2020-10-13T14:51:20.131-04:00 | at Sentry.withScope (/var/task/src/adapters/graphql/handler.js:645514:45)
  | 2020-10-13T14:51:20.131-04:00 | at Hub.withScope (/var/task/src/adapters/graphql/handler.js:654823:13)
  | 2020-10-13T14:51:20.131-04:00 | at callOnHub (/var/task/src/adapters/graphql/handler.js:13438:28)
  | 2020-10-13T14:51:20.131-04:00 | at Module.withScope (/var/task/src/adapters/graphql/handler.js:13572:5)

After analyzing the bundle we noticed that the it happens in the dynamicRequire function specifically when it's called from packages/utils/src/node.ts line 93 which was introduced in version 5.24.0.

Checking the stacktrace it happens when Handlers.parseRequests is called from the Nest-Raven library we use

So far the workaround is to keep using @sentry/node@5.23.0 where the error does not happen.

[rodolfoBee]

@sergio-dreamcode can you provide a simple repro app?

[kamilchlebek]

@rbisol Here's the repo https://github.com/kamilchlebek/sentry-express-demo

Run: npm start and provide environment variable SSR_SENTRY_DSN. Open localhost:4500/debug-sentry to trigger an error.

I think it's caused by webpack bundling, have a look at this thread: #2515

[sergio-dreamcode]

Thanks for the sample repo @kamilchlebek. As you mentioned it is possible to be related with webpack by checking #2515. That PR removed the usage of dynamicRequire however it was introduced again as part of 5.24.0 #2820

[ybrodsky]

@sergio-dreamcode wil #2515 be re-instated? Or was the #2820 reintroduction intentional?

[sergio-dreamcode]

wil #2515 be re-instated? Or was the #2820 reintroduction intentional?

@ybrodsky I'm not sure, I checked in #2515 that removed dynamicRequire but in #2524 it was restored only for hooks so it was not breaking anything. The change in #2820 seems to be related with hooks but this time is breaking webpack builds as no events can be reported causing the mod.require error.

[ch1ller0]

Hi, we have encountered the same issue, the only workaround for us was to downgrade to 5.22.0. Any progress on a problem yet?

[dvins]

@rbisol Any updates from Sentry on this?

[RatkoR]

Hi all, we're running sentry in nodejs angular universal project and we also get this error (in 5.24 and higher versions). I'll be glad to help, if If you need me to try anything.

I tried using import as in getsentry/sentry-electron#92 (comment) but it doesn't work

import { init } from '@sentry/node/dist/index';
import * as Sentry from '@sentry/node';

Any other ideas?

[RatkoR]

To reproduce this, take angular universal zip from https://angular.io/guide/universal and add @sentry/node to it.

A request to /debug-sentry logs a mod.require is not a function error and not My first Sentry error.

[sergio-dreamcode]

@rbisol I think we should remove the Needs Reproduction tag because @kamilchlebek already provided a repository to reproduce the issue.

[dvins]

@rbisol This has been open and reproducible nearly three months. Downgrading the package version not an appropriate solution. Any updates?