[Ember] Type Problem Introduced in v6.10?

[jherdman]

• Review the documentation: https://docs.sentry.io/
• Search for existing issues: https://github.com/getsentry/sentry-javascript/issues
• Use the latest release: https://github.com/getsentry/sentry-javascript/releases (N/A)
• Provide a link to the affected event from your Sentry account (N/A)

Package + Version

• @sentry/browser:
• @sentry/node
• raven-js
• raven-node (raven for node)
• other: @sentry/ember

Version:

6.10.0+

Description

In upgrading an application using @sentry/ember v6.6.0 to v6.15 we ran into some peculiar type regressions. Here's a snippet of our code that worked before:

    assert(
      '[ember-metrics] You must configure Heap adapter. See documentation.',
      typeof config !== 'undefined'
    );

    const { appId, pageViewPrefix } = config;

Using v6.6.0 this code works, but suddenly, when v6.10 (or later), is introduced we see the type for assert fail.

I'm not entirely sure this is the problem, but this is a bit of a smoking gun:

sentry-javascript/packages/ember/addon/index.ts

Lines 11 to 13 in a72ea44

	declare module '@ember/debug' {
	export function assert(desc: string, test: unknown): void;
	}

Note that this typing differs from the DefinitelyTyped version:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/4a4f37536cec0d38819acd9015600de7715ac6b3/types/ember__debug/index.d.ts#L10-L14

I believe that If you were to use the @types/ember__debug package instead of rolling your own type this problem should be resolved.

[jherdman]

#4173 — though I cannot confirm yet that this resolves our issue. I'm still exploring the changes introduced by v6.10.

[jherdman]

Correction: I see this merely by moving to v6.9

[k-fish]

@jherdman great suggestion, will follow up in the PR.

[AbhiPrasad]

@jherdman just wanted to circle back to ask if you were still encountering these issues?

[jherdman]

Confirmed! Many thanks.