Cannot build on Windows due to Bash usage

[timfish]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

SDK Version

master

Steps to Reproduce

yarn && yarn build

Expected Result

Builds

Actual Result

Fails on bash scripts/buildBundles.sh

[lobsterkatie]

@timfish - Can you say more about what actually goes wrong? What about the script is it unhappy with?

[timfish]

Windows does not have bash so the script completely fails to run.

I suppose WSL might work but this was never a requirement before and it's a huge dependency.

[lobsterkatie]

Windows does not have bash so the script completely fails to run.

Forgive my ignorance, but really? I feel like shell scripts are all over the place in software development. Can folks who use windows machines truly not run any of them (without WSL, at least, which is sounds like isn't a part of your normal setup or an everyday thing)? What do you do instead? There are other bash scripts in the repo. How do you run them?

[kamilogorek]

Yup, you need a WSL (now) or Cygwin, MinGW or msys (old days) 🥲

[Lms24]

This also applies to scripts/postbuild.sh (currently) when building @sentry/browser
(although this could be easily replaced by a Node script, I suppose)

[timfish]

I feel like shell scripts are all over the place in software development.

Shell scripts may be common in some areas of software development but they are rare in the node.js ecosystem.

JavaScript projects stick to package.json scripts and node.js scripts to retain cross platform compatibility and to reduce barriers to outside contribution.

For things like Relay where there are few outside contributions, Windows support doesn't really matter but for a repository like this there should be a policy over whether to stick to solely node.js or not.

There are other bash scripts in the repo. How do you run them?

When issues pop up in the build or unit tests I submit PR's to fix them! Currently, I just let the integration tests run in CI.