fix(core): Prevent outgoing HTTP instrumentation from crashing on // request paths#21645
Merged
logaretm merged 1 commit intoJun 18, 2026
Merged
Conversation
logaretm
requested review from
a team,
JPeer264,
andreiborza and
mydea
and removed request for
a team and
mydea
…` request paths The outgoing-request instrumentation builds a URL from the request path via `new URL(path, base)`. A path starting with `//` (valid for e.g. S3 object keys like `//Trust scores/test.html`) is parsed as a protocol-relative reference, discarding the request origin and treating the path as the authority — which throws `TypeError: Invalid URL` for authorities the parser rejects. Because this runs synchronously inside `diagnostics_channel.publish()` during the `ClientRequest` constructor, the throw becomes an uncaught exception that crashes the host process (crash-looping in the reported case). Resolve `//`-prefixed paths against the request origin as absolute paths so they produce the correct URL, and wrap `getRequestUrl` in a try/catch returning `''` so the instrumentation can never take down the application. Fixes #21627 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
logaretm
force-pushed
the
fix/http-instrumentation-double-slash-path-crash
branch
from
ea3781d to
104200d
Compare
Contributor
size-limit report 📦
|
andreiborza
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures protocol relative URLs are safe to parse (e.g: s3 URLs), shouldn't change any existing behaviors.
closes #21627