fix(serve-rutils): Orchestrion diagnostics for async and require#22327
Merged
Conversation
timfish
requested review from
isaacs,
mydea,
s1gr1d and
stephanie-anderson
and removed request for
a team
July 16, 2026 13:17
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
size-limit report 📦
|
mydea
approved these changes
Jul 16, 2026
mydea
changed the title
timfish
added a commit
that referenced
this pull request
Jul 16, 2026
I missed this commit off of #22327. This ensure that we only skip registering the hooks on the loader thread which means Sentry in a worker thread can still hook loading.
49 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues with capturing runtime orchestrion diagnostics:
Notes:
require(esm).registerDiagnosticsChannelInjectionfrom running on the loader thread or it crashes!DEBUG_BUILDbecause this code is all server side and we want these to always be captured whendebug: true. Probably worth adjusting the ai prompt to reflect this!