fix(profiling-node): Respect profileSessionSampleRate in trace profile lifecycle - #22928
Merged
Lms24 merged 2 commits intoAug 3, 2026
Merged
Conversation
Jxxunnn
requested review from
andreiborza and
mydea
and removed request for
a team
August 1, 2026 09:14
Lms24
force-pushed
the
fix/profiling-node-trace-session-sample-rate
branch
from
August 3, 2026 07:44
c770749 to
be8ca07
Compare
nicohrubec
pushed a commit
that referenced
this pull request
Aug 3, 2026
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #22928 Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
Member
|
One thing to note: this change now requires that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yarn lint) & (yarn test).Closes #22927
When using the
traceprofile lifecycle in@sentry/profiling-node, trace lifecycle profiling was set up without checking the session sampling decision. As a result, chunk profiling would start on span start even whenprofileSessionSampleRateresulted in an unsampled session.This change skips trace lifecycle profiling setup when the session is not sampled, ensuring that
profileSessionSampleRateis respected in thetracelifecycle as well.A regression test was added for
profileSessionSampleRate: 0with thetraceprofile lifecycle.