Skip to content

test(effect): Re-enable effect server transaction e2e tests #23059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreiborza merged 1 commit into from
Aug 5, 2026
+8 −22
Merged

test(effect): Re-enable effect server transaction e2e tests #23059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions dev-packages/e2e-tests/test-applications/effect-3-node/tests/transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,7 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';

// TODO(v11): `@sentry/effect` server used to run on `@sentry/node-core/light`, which set an
// AsyncLocalStorage-based async context strategy that matched Effect's fiber model, so the Effect
// tracer's spans became the `http.server GET` transaction. On full `@sentry/node` the SDK installs
// the OpenTelemetry context strategy instead, and the Effect tracer's span context no longer
// propagates as expected, so no transaction is emitted. Marked fixme until the Effect SDK's server
// tracing is adapted to the full-node async context model.

test.fixme('Sends an HTTP transaction', async ({ baseURL }) => {
test('Sends an HTTP transaction', async ({ baseURL }) => {
const transactionEventPromise = waitForTransaction('effect-3-node', transactionEvent => {
return transactionEvent?.transaction === 'http.server GET';
});
Expand All @@ -20,7 +13,7 @@ test.fixme('Sends an HTTP transaction', async ({ baseURL }) => {
expect(transactionEvent.transaction).toBe('http.server GET');
});

test.fixme('Sends transaction with manual Effect span', async ({ baseURL }) => {
test('Sends transaction with manual Effect span', async ({ baseURL }) => {
const transactionEventPromise = waitForTransaction('effect-3-node', transactionEvent => {
return (
transactionEvent?.transaction === 'http.server GET' &&
Expand All @@ -42,7 +35,7 @@ test.fixme('Sends transaction with manual Effect span', async ({ baseURL }) => {
]);
});

test.fixme('Sends Effect spans with correct parent-child structure', async ({ baseURL }) => {
test('Sends Effect spans with correct parent-child structure', async ({ baseURL }) => {
const transactionEventPromise = waitForTransaction('effect-3-node', transactionEvent => {
return (
transactionEvent?.transaction === 'http.server GET' &&
Expand Down Expand Up @@ -93,7 +86,7 @@ test.fixme('Sends Effect spans with correct parent-child structure', async ({ ba
expect(nestedSpan).toBe(parentSpan);
});

test.fixme('Sends transaction for error route', async ({ baseURL }) => {
test('Sends transaction for error route', async ({ baseURL }) => {
const transactionEventPromise = waitForTransaction('effect-3-node', transactionEvent => {
return transactionEvent?.transaction === 'http.server GET';
});
Expand Down
15 changes: 4 additions & 11 deletions dev-packages/e2e-tests/test-applications/effect-4-node/tests/transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,7 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';

// TODO(v11): `@sentry/effect` server used to run on `@sentry/node-core/light`, which set an
// AsyncLocalStorage-based async context strategy that matched Effect's fiber model, so the Effect
// tracer's spans became the `http.server GET` transaction. On full `@sentry/node` the SDK installs
// the OpenTelemetry context strategy instead, and the Effect tracer's span context no longer
// propagates as expected, so no transaction is emitted. Marked fixme until the Effect SDK's server
// tracing is adapted to the full-node async context model.

test.fixme('Sends an HTTP transaction', async ({ baseURL }) => {
test('Sends an HTTP transaction', async ({ baseURL }) => {
const transactionEventPromise = waitForTransaction('effect-4-node', transactionEvent => {
return transactionEvent?.transaction === 'http.server GET';
});
Expand All @@ -20,7 +13,7 @@ test.fixme('Sends an HTTP transaction', async ({ baseURL }) => {
expect(transactionEvent.transaction).toBe('http.server GET');
});

test.fixme('Sends transaction with manual Effect span', async ({ baseURL }) => {
test('Sends transaction with manual Effect span', async ({ baseURL }) => {
const transactionEventPromise = waitForTransaction('effect-4-node', transactionEvent => {
return (
transactionEvent?.transaction === 'http.server GET' &&
Expand All @@ -42,7 +35,7 @@ test.fixme('Sends transaction with manual Effect span', async ({ baseURL }) => {
]);
});

test.fixme('Sends Effect spans with correct parent-child structure', async ({ baseURL }) => {
test('Sends Effect spans with correct parent-child structure', async ({ baseURL }) => {
const transactionEventPromise = waitForTransaction('effect-4-node', transactionEvent => {
return (
transactionEvent?.transaction === 'http.server GET' &&
Expand Down Expand Up @@ -93,7 +86,7 @@ test.fixme('Sends Effect spans with correct parent-child structure', async ({ ba
expect(nestedSpan).toBe(parentSpan);
});

test.fixme('Sends transaction for error route', async ({ baseURL }) => {
test('Sends transaction for error route', async ({ baseURL }) => {
const transactionEventPromise = waitForTransaction('effect-4-node', transactionEvent => {
return transactionEvent?.transaction === 'http.server GET';
});
Expand Down
Loading