feat(solidstart): Add SolidStart 2 support - #23090
Open
chargome wants to merge 3 commits into
Open
Conversation
SolidStart 2 drops vinxi and `app.config.ts`, so `withSentry` has nothing to wrap — the only integration surface left is a Vite plugin. Add `sentrySolidStart()` under a new `@sentry/solidstart/vite` subexport. The SolidStart 1 path is untouched. It contributes the `@sentry/nitro` module, the orchestrion build-time transform, and client source map upload. Sentry is initialized from a user-authored Nitro plugin — build-time instrumentation means no `--import` preload and no instrumentation file copied into the build output. Also widen the `@solidjs/start` peer to `^1.0.0 || ^2.0.0` and add a `default` export condition, without which the package does not resolve on non-Node runtimes. Fixes #23029 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
Nothing in the package imports `nitro` directly — only `nitropack` for the SolidStart 1 path, and `@sentry/nitro` for the rest. Carrying it bumped the hoisted `nitro` version and pulled 15 rolldown platform binaries into the lockfile for no benefit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chargome
marked this pull request as ready for review
August 6, 2026 12:23
chargome
requested review from
andreiborza,
nicohrubec and
s1gr1d
and removed request for
a team and
s1gr1d
August 6, 2026 12:23
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c5c853a. Configure here.
…ite hook The plugin returned a copy of the user's whole `nitro` config. Vite concatenates arrays when merging a `config` hook's return value, so every entry the user had in `nitro.modules`, `nitro.plugins` and the like was duplicated before Nitro ever saw it. Hand `setupSentryNitroModule` only the keys it reads, so what comes back is purely Sentry's additions and Vite's merge appends them. Covered by a test that runs the real `mergeConfig`, which the previous test missed by asserting on the hook's return value alone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SolidStart 2 drops vinxi and
app.config.ts, sowithSentryhas nothing to wrap — the only integration surface left is a Vite plugin. AddssentrySolidStart()under a new@sentry/solidstart/vitesubexport. The SolidStart 1 path is untouched.It contributes the
@sentry/nitromodule, the orchestrion build-time transform, and client source map upload. Sentry is initialized from a user-authored Nitro plugin — build-time instrumentation means no--importpreload and no instrumentation file copied into the build output.Also widens the
@solidjs/startpeer to^1.0.0 || ^2.0.0and adds adefaultexport condition, without which the package does not resolve on non-Node runtimes.Fixes #23029