fix(core): Filter query params in url.full on request data and navigate errors - #23143
Merged
chargome merged 2 commits intoAug 7, 2026
Merged
Conversation
Contributor
size-limit report 📦
|
chargome
marked this pull request as ready for review
August 7, 2026 10:30
chargome
requested review from
Lms24,
mydea,
nicohrubec and
s1gr1d
and removed request for
a team,
mydea and
s1gr1d
August 7, 2026 10:30
andreiborza
approved these changes
Aug 7, 2026
nicohrubec
approved these changes
Aug 7, 2026
…gate errors Two sites set `url.full` from a raw URL, so query params reached Sentry even though `dataCollection.urlQueryParams` was configured to filter them. `requestDataIntegration` filtered `url.query` on the segment span but left `url.full` untouched, so the same span carried both the filtered and the unfiltered query string. On the react-router client, the `url.full` reported for a failed navigate came from the app's own navigate target, which can include a query. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chargome
force-pushed
the
fix/filter-url-full-in-requestdata-and-navigate
branch
from
August 7, 2026 10:50
9cfe5d6 to
962995a
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
`addNormalizedRequestDataToEvent` filtered cookies, headers and `query_string` but spread the raw URL into `event.request.url`, so an error event carried the query string even with `dataCollection.urlQueryParams: false` — the same secret the SDK had just dropped from `query_string`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
JPeer264
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two sites set
url.fullfrom a raw URL, so query params reached Sentry despitedataCollection.urlQueryParams.Follow-up to #23061, which added the URL filtering. Found by the lint rule in the PR stacked on top of this one 😄 .