fix(types): Use Sentry event type instead of dom one#4584
Merged
Conversation
#4527 introduced Envelope types. In that patch, we included the `Event` DOM type, which is not declared in all TS environments accidentally - we meant to include Sentry's `Event` type. This patch explicitly introduces Sentry's Event type by importing it in, fixing the build errors that folks were having.
AbhiPrasad
requested review from
a team,
Lms24 and
lobsterkatie
and removed request for
a team
Contributor
size-limit report
|
lobsterkatie
approved these changes
Feb 15, 2022
|
|
||
| ## 6.17.9 | ||
|
|
||
| - fix(gatsby): Add missing React peer dependency ([#4576](https://github.com/getsentry/sentry-javascript/pull/4576)) |
Contributor
There was a problem hiding this comment.
@AbhiPrasad do we want to thank external contributor for this PR #4576
Contributor
Author
There was a problem hiding this comment.
Yeah we should make the edit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4527 introduced
Envelope types. In that patch, we included the
EventDOM type, whichis not declared in all TS environments. This was done accidentally, we meant to
include Sentry's
Eventtype.This patch explicitly introduces Sentry's Event type by importing it in,
fixing the build errors that folks were having.
I would like to release after this, so I am going to update the changelog in this PR as well.
Fixes #4583