fix(tracing): Make method required in transactionSampling type#4657
Merged
lobsterkatie merged 1 commit intoMar 1, 2022
Merged
Conversation
Contributor
|
Nvm just saw your change in #4656 (comment) |
AbhiPrasad
approved these changes
Mar 1, 2022
Member
Author
You're too fast, LOL. See my comment on the linked PR. Had to submit this before I could submit that. |
Contributor
size-limit report
|
AbhiPrasad
pushed a commit
that referenced
this pull request
Mar 2, 2022
…4657) Though every transaction should have `transactionSampling` metadata, we mark the property as optional because we add it after the transaction is created, in the process of computing a sampling decision for it. Once `transactionSampling` exists, however, it should always have a `method` property.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Though every transaction should have
transactionSamplingmetadata, we mark the property as optional because we add it after the transaction is created, in the process of computing a sampling decision for it. OncetransactionSamplingexists, however, it should always have amethodproperty.