Skip to content

fix(angular): Stop routing spans on navigation cancel and error events #8369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 3 commits into from
Jun 20, 2023
Merged

fix(angular): Stop routing spans on navigation cancel and error events #8369

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2276e2
fix(angular): Stop routing spans on navigation cancel and error events
Lms24 Jun 20, 2023
d5d418e
cleanup test setup
Lms24 Jun 20, 2023
9adca3e
linter
Lms24 Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup test setup
  • Loading branch information
@Lms24
Lms24 committed Jun 20, 2023
commit d5d418e8c27352a4c6e3396fd7cd9869f7c75775
9 changes: 4 additions & 5 deletions packages/angular/test/utils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,15 +61,16 @@ export class TestEnv {
TestBed.configureTestingModule({
imports: [AppModule, RouterTestingModule.withRoutes(routes)],
declarations: [...(conf.components || []), AppComponent],
providers: useTraceService
providers: (useTraceService
? [
{
provide: TraceService,
deps: [Router],
},
...(conf.additionalProviders || []),
]
: [...(conf.additionalProviders || [])],
: []
).concat(...(conf.additionalProviders || [])),
});

const router: Router = TestBed.inject(Router);
Expand All @@ -88,9 +89,7 @@ export class TestEnv {
this.fixture.detectChanges();
resolve();
})
.catch(err => {
console.log({ err });

.catch(() => {
this.fixture.detectChanges();
resolve();
});
Expand Down