Skip to content

fix(replay): Add additional safeguards for capturing network bodies #9506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mydea merged 3 commits into from
Nov 10, 2023
Merged

fix(replay): Add additional safeguards for capturing network bodies #9506

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae7b106
fix(replay): Add additional safeguards for capturing network bodies
mydea Nov 9, 2023
97767d4
add log for body parsing error
mydea Nov 10, 2023
6d0e4d4
log for failed serialized response body
mydea Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add log for body parsing error
  • Loading branch information
@mydea
mydea committed Nov 10, 2023
commit 97767d44a5ca2d05f2e72afe280fbfff3a90dac6
6 changes: 4 additions & 2 deletions packages/replay/src/coreHandlers/util/networkUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { TextEncoderInternal } from '@sentry/types';
import { dropUndefinedKeys, stringMatchesSomePattern } from '@sentry/utils';
import { dropUndefinedKeys, logger, stringMatchesSomePattern } from '@sentry/utils';

import { NETWORK_BODY_MAX_SIZE, WINDOW } from '../../constants';
import type {
Expand Down Expand Up @@ -74,7 +74,9 @@ export function getBodyString(body: unknown): string | undefined {
if (body instanceof FormData) {
return _serializeFormData(body);
}
} catch {} // eslint-disable-line no-empty
} catch {
__DEBUG_BUILD__ && logger.warn('[Replay] Failed to serialize body', body);
}

return undefined;
}
Expand Down