feat: add sentry_set_release/environment#1555
Merged
Merged
Conversation
Add post-init setters for release and environment, allowing apps to update these values after SDK init without full re-init. The new values are stored on the scope (like user), keeping options immutable after init. Sessions pick up the new values when manually started after calling the setters. Close: #1516 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Acquire options lock before scope lock in sentry_set_release_n and sentry_set_environment_n to match the lock order used by sentry_init (options → scope), fixing a potential deadlock detected by TSan. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use SENTRY_WITH_SCOPE_MUT instead of _NO_FLUSH so that crashpad re-serializes its cached crash event when release or environment changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
`sentry_start_session()` already holds the scope lock, so pass the scope pointer directly instead of re-acquiring it inside `sentry__session_new()`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
supervacuus
approved these changes
Mar 9, 2026
supervacuus
left a comment
supervacuus
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, but I don't think we need to redo the DSC construction.
Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
1 task
This was referenced Mar 17, 2026
BernhardMarconato
pushed a commit
to elgatosf/sentry-native
that referenced
this pull request
Apr 21, 2026
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add post-init setters for release and environment, allowing apps to update these values after SDK init, without requiring a full shutdown and re-init.
The new values are stored on the scope (like user), keeping options immutable after init. Sessions pick up the new values when manually started after calling the setters.
Close: #1516