fix: Cap JSON parser depth#1748
Open
jpnurmi wants to merge 2 commits into
Open
Conversation
Reject JSON inputs whose object or array nesting exceeds 64 levels. The parser previously recursed once per nested container with no limit, so crafted cached JSON could exhaust the C call stack during SDK startup or envelope/session processing. Use 64 because the JSON writer already uses that maximum depth. Matching the writer preserves the SDK's existing JSON depth policy: JSON the SDK can emit remains accepted, while deeper untrusted input is rejected. Msgpack deserialization was already capped. Raise that existing cap from 32 to 64 because msgpack uses the same recursive value conversion shape, and 64 is the stack-safe bound chosen for JSON. Co-Authored-By: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject JSON inputs whose object or array nesting exceeds 64 levels. The parser previously recursed once per nested container with no limit, so crafted cached JSON could exhaust the C call stack during SDK startup or envelope/session processing.
Use 64 because the JSON writer already uses that maximum depth. Matching the writer preserves the SDK's existing JSON depth policy: JSON the SDK can emit remains accepted, while deeper untrusted input is rejected.
Msgpack deserialization was already capped in #1727. Raise that existing cap from 32 to 64 because msgpack uses the same recursive value conversion shape.