chore: Revert buf exceptions#169
Merged
Merged
Conversation
In #168 I removed unused protos and in order to do that I had to temporarily lift deletion rules. This restores those rules.
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
Dav1dde
approved these changes
Jan 27, 2026
4 tasks
armcknight
pushed a commit
that referenced
this pull request
Jun 12, 2026
…stead of removing The previous attempt (commit 67ce9cf) removed fields 7 (``refunded``) and 8 (``amount_refunded``) and replaced them with ``reserved 7, 8;`` so the field numbers couldn't be re-used. That tripped buf's ``FIELD_NO_DELETE`` rule, which sentry-protos enables deliberately: PR #168 lifted it once to clean up unused prototype protos, and PR #169 immediately restored it as a permanent guardrail. Restoring the fields with ``[deprecated = true]`` so: - buf is happy (no field deletion). - Consumers get a deprecation marker steering them toward ``refunds[*].amount_cents`` as the source of truth. - No drift risk in practice: the getsentry-side producer (``_charge_to_proto``) is already not populating these fields (getsentry#20611 commit ``96fd005``), and a search confirms no getsentry code reads ``PlatformCharge.refunded`` / ``PlatformCharge.amount_refunded`` -- the proto is internal to the billing platform service. This matches the spirit of Noah's review feedback (don't carry a cache that can drift from the rows) while respecting the repo's field- deletion policy. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #168 I removed unused protos and in order to do that I had to temporarily lift deletion rules. This restores those rules.