chore(billing-platform): Add protos for set_pending_tax_transaction endpoint#315
Closed
dashed wants to merge 2 commits into
Closed
chore(billing-platform): Add protos for set_pending_tax_transaction endpoint#315dashed wants to merge 2 commits into
dashed wants to merge 2 commits into
Conversation
…ndpoint Records the tax provider's document reference on an invoice as a pending tax transaction so it can be committed or voided once the charge outcome is known. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
This was referenced Jun 18, 2026
Member
Author
|
Superseded by #319. The atomic-linkage refactor (getsentry getsentry/getsentry#20754) folds the tax-document linkage into the contract create/rollover requests ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
SetPendingTaxTransactionrequest/response messages to the contract service for the PR https://github.com/getsentry/getsentry/pull/20624.SetPendingTaxTransactionRequestcarries theinvoice_idand the tax provider'sexternal_reference;SetPendingTaxTransactionResponsereturns whether a matching invoice was updated. These back the getsentry contract service'sset_pending_tax_transaction, which records the provider-side tax document reference on an invoice as a pending tax transaction so it can be committed or voided once the charge outcome is known. That method is currently prototyped with proto-free dataclasses (the dataclass-prototype pattern); these messages are what it migrates to.Message-only and consistent with the other contract endpoints —
uint64 invoice_id, barestring, oneendpoint_*.protofor the pair, mirroringMarkInvoicePaid. Generated stubs are produced at build time, so only the.protosource is included here.