Investigate the RN new architecture

[marandaneto]

https://reactnative.dev/docs/next/new-architecture-intro#table-of-contents

The goal is to identify breaking changes with the current Sentry RN SDK.
Consider upgrading to the latest stable version as well https://react-native-community.github.io/upgrade-helper/?from=0.66.2&to=0.68.1
https://reactnative.dev/blog/2022/06/16/resources-migrating-your-react-native-library-to-the-new-architecture

Docs for migrating
Discussions new architecture
Examples with steps
Already migrated libs to take as an example

[github-actions]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[marandaneto]

Why the new architecture?
It uses JSI instead of the Bridge and other improvements.

TurboModules: Ensure your App Provides an RCTCxxBridgeDelegate
Fabric is the new RN's rendering system.
Min Gradle and AGP version are 7.x.
Hermes is enabled by default also here.
iOS uses C++ 17 language features.
iOS use Objective C++ and requires .mm extension.
React 18 enabled by default.
Min RN version is 0.68.
CodeGen requires min RN version 0.70.

SentryNativeBridgeModule is likely going to be auto generated and has to be adapted.

• Drop RN versions older than 0.60.x 0.70.x, Check "react-native": ">=$version" on package.json
• Import NativeModules on index.ts
• Import RCTBridgeModule on RNSentry.h
• Use RCT_REMAP_METHOD on RNSentry.m
• Patch build script on Android on build.gradle
• Add Turbo module on JS on RNSentry.ts NativeRNSentry.ts (naming convention given by the codegen scripts)
• Add Turbo codegen on iOS on package.json
• Add Turbo codegen on Android on build.gradle
• Patch podspec on iOS on RNSentry.podspec
• Patch RCT_NEW_ARCH_ENABLED on iOS on RNSentry.m RNSentry.mm
• Make RNSentryPackage backward compatible on Android on RNSentryPackage.java
• Patch build script with IS_NEW_ARCHITECTURE_ENABLED on Android on build.gradle
• Patch package with IS_NEW_ARCHITECTURE_ENABLED on Android on RNSentryPackage.java
• Create Codegen a NativeSentrySpec on Android
• Create an impl of ReactContextBaseJavaModule on Android
• Refactor the ModuleImpl to use the implementation created above on Android
• Unify the JS interface on index.ts
• Test Android and iOS with new architecture
• Test Android and iOS with the old architecture
• Fix sentry-wizard with new iOS command
• Bump Sentry-CLI

Ps:

Autolinking doesn’t work with the new architecture out of the box. Therefore you need to ask the user of your library to do the following steps

https://github.com/react-native-community/RNNewArchitectureLibraries/tree/feat/back-turbomodule#android-autolinking=

We could patch https://github.com/getsentry/sentry-wizard to do that but we don't know if the new architecture is enabled or not within the final app.

Chrome debugging doesn't work on New Architecture

[cipolleschi]

Consider upgrading to the latest stable version as well https://react-native-community.github.io/upgrade-helper/?from=0.66.2&to=0.68.1

The new stable version is 0.69.3

CodeGen requires min RN version 0.70.

Not really. Codegen works starting from the 0.67, however we worked on improving it and trying to simplify the setup. The page you linked is a draft of how to use Codegen that will be released together with 0.70, where we changed the syntax of the package.json and we unified how it should work for both ios and android.

Autolinking doesn’t work with the new architecture out of the box. Therefore you need to ask the user of your library to do the following steps

Autolinking for iOS works since 0.68.
Autolinking for Android is coming with 0.70.

[marandaneto]

@cipolleschi Thank you.