chore(deps): Bumps JavaScript SDK to v8.41.0 by antonis · Pull Request #4351 · getsentry/sentry-react-native

antonis · 2024-12-09T11:57:22Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Bumps JavaScript SDK to v8.41.0 and fixes broken tests (see this comment for context)
See #4325 for the changelog.

💡 Motivation and Context

Bumping #4325 from 8.41.0 to 8.42.0 introduced new breaking changes. This PR attempts to handle the 8.41.0 changes 1st for simplicity.

💚 How did you test it?

CI, Manually

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#4325

github-actions · 2024-12-09T12:09:09Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	707.14 ms	700.55 ms	-6.59 ms
Size	17.74 MiB	20.08 MiB	2.35 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e22745e`	462.66 ms	458.10 ms	-4.56 ms
`70e6261`	482.65 ms	495.70 ms	13.05 ms
`575f9da`	415.26 ms	422.98 ms	7.72 ms
`e5bc97b`	438.96 ms	437.39 ms	-1.57 ms
`77680ec`	482.22 ms	475.07 ms	-7.16 ms
`e1ea4a8`	506.82 ms	510.48 ms	3.66 ms
`15c80ab`+dirty	336.27 ms	350.58 ms	14.31 ms
`13f280b`	486.16 ms	472.45 ms	-13.71 ms
`12427f4`	393.69 ms	414.84 ms	21.14 ms
`abb7058`	370.27 ms	389.58 ms	19.31 ms

App size

Revision	Plain	With Sentry	Diff
`e22745e`	17.74 MiB	20.08 MiB	2.34 MiB
`70e6261`	17.73 MiB	19.94 MiB	2.21 MiB
`575f9da`	17.73 MiB	19.83 MiB	2.10 MiB
`e5bc97b`	17.74 MiB	20.08 MiB	2.34 MiB
`77680ec`	17.74 MiB	20.08 MiB	2.34 MiB
`e1ea4a8`	17.74 MiB	20.08 MiB	2.34 MiB
`15c80ab`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`13f280b`	17.74 MiB	20.08 MiB	2.34 MiB
`12427f4`	17.73 MiB	19.85 MiB	2.12 MiB
`abb7058`	17.73 MiB	19.83 MiB	2.10 MiB

Previous results on branch: antonis/bump-JavaScriptSDK-to-8.41.0

Startup times

Revision	Plain	With Sentry	Diff
`b2b0b65`	495.25 ms	480.74 ms	-14.51 ms
`13fff3c`	457.76 ms	467.66 ms	9.90 ms

App size

Revision	Plain	With Sentry	Diff
`b2b0b65`	17.74 MiB	20.08 MiB	2.35 MiB
`13fff3c`	17.74 MiB	20.08 MiB	2.35 MiB

github-actions · 2024-12-09T12:18:13Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	406.47 ms	471.37 ms	64.90 ms
Size	7.15 MiB	8.37 MiB	1.22 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`c2a4e9b`+dirty	392.94 ms	474.55 ms	81.61 ms
`7fd512a`+dirty	439.69 ms	503.71 ms	64.01 ms
`e1ea4a8`+dirty	451.98 ms	497.58 ms	45.60 ms
`b8ff156`+dirty	386.72 ms	398.18 ms	11.46 ms
`d8668ce`+dirty	372.43 ms	403.84 ms	31.41 ms
`12427f4`+dirty	379.48 ms	400.92 ms	21.44 ms
`5446992`+dirty	371.61 ms	390.00 ms	18.39 ms
`15c80ab`+dirty	276.38 ms	327.54 ms	51.17 ms
`ddc0552`+dirty	405.80 ms	480.00 ms	74.20 ms
`ed3d77e`+dirty	366.04 ms	411.33 ms	45.28 ms

App size

Revision	Plain	With Sentry	Diff
`c2a4e9b`+dirty	7.15 MiB	8.34 MiB	1.19 MiB
`7fd512a`+dirty	7.15 MiB	8.35 MiB	1.21 MiB
`e1ea4a8`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`b8ff156`+dirty	7.15 MiB	8.37 MiB	1.22 MiB
`d8668ce`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`12427f4`+dirty	7.15 MiB	8.12 MiB	997.78 KiB
`5446992`+dirty	7.15 MiB	8.12 MiB	999.45 KiB
`15c80ab`+dirty	7.15 MiB	8.09 MiB	966.13 KiB
`ddc0552`+dirty	7.15 MiB	8.37 MiB	1.22 MiB
`ed3d77e`+dirty	7.15 MiB	8.35 MiB	1.21 MiB

Previous results on branch: antonis/bump-JavaScriptSDK-to-8.41.0

Startup times

Revision	Plain	With Sentry	Diff
`13fff3c`+dirty	417.14 ms	453.34 ms	36.20 ms
`b2b0b65`+dirty	373.24 ms	417.80 ms	44.57 ms

App size

Revision	Plain	With Sentry	Diff
`13fff3c`+dirty	7.15 MiB	8.37 MiB	1.22 MiB
`b2b0b65`+dirty	7.15 MiB	8.37 MiB	1.22 MiB

github-actions · 2024-12-09T12:23:22Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1223.77 ms	1218.27 ms	-5.50 ms
Size	2.36 MiB	3.10 MiB	759.42 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d8668ce`+dirty	1225.18 ms	1228.08 ms	2.90 ms
`8de2810`+dirty	1230.84 ms	1226.35 ms	-4.49 ms
`1332acb`+dirty	1230.53 ms	1234.54 ms	4.01 ms
`eb1e19f`+dirty	1209.56 ms	1214.94 ms	5.38 ms
`61310e1`+dirty	1216.06 ms	1220.64 ms	4.58 ms
`a989877`+dirty	1228.56 ms	1227.71 ms	-0.85 ms
`1faf8e3`+dirty	1214.87 ms	1222.83 ms	7.97 ms
`75774ea`+dirty	1231.33 ms	1243.39 ms	12.06 ms
`6e8584e`+dirty	1274.50 ms	1296.82 ms	22.32 ms
`484813b`+dirty	1222.45 ms	1220.79 ms	-1.66 ms

App size

Revision	Plain	With Sentry	Diff
`d8668ce`+dirty	2.36 MiB	3.08 MiB	737.08 KiB
`8de2810`+dirty	2.36 MiB	3.10 MiB	752.30 KiB
`1332acb`+dirty	2.36 MiB	3.11 MiB	759.86 KiB
`eb1e19f`+dirty	2.36 MiB	3.08 MiB	737.21 KiB
`61310e1`+dirty	2.36 MiB	3.10 MiB	757.92 KiB
`a989877`+dirty	2.36 MiB	3.10 MiB	752.40 KiB
`1faf8e3`+dirty	2.36 MiB	3.08 MiB	736.75 KiB
`75774ea`+dirty	2.36 MiB	3.10 MiB	757.87 KiB
`6e8584e`+dirty	2.36 MiB	2.88 MiB	533.17 KiB
`484813b`+dirty	2.36 MiB	3.08 MiB	734.18 KiB

Previous results on branch: antonis/bump-JavaScriptSDK-to-8.41.0

Startup times

Revision	Plain	With Sentry	Diff
`13fff3c`+dirty	1219.52 ms	1215.23 ms	-4.29 ms
`b2b0b65`+dirty	1221.98 ms	1226.30 ms	4.32 ms

App size

Revision	Plain	With Sentry	Diff
`13fff3c`+dirty	2.36 MiB	3.10 MiB	759.45 KiB
`b2b0b65`+dirty	2.36 MiB	3.10 MiB	759.42 KiB

github-actions · 2024-12-09T12:25:06Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1252.94 ms	1241.19 ms	-11.75 ms
Size	2.92 MiB	3.67 MiB	771.97 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d8668ce`+dirty	1249.70 ms	1242.31 ms	-7.39 ms
`8de2810`+dirty	1238.15 ms	1236.31 ms	-1.84 ms
`1332acb`+dirty	1243.98 ms	1241.12 ms	-2.86 ms
`eb1e19f`+dirty	1229.91 ms	1231.63 ms	1.71 ms
`61310e1`+dirty	1229.04 ms	1238.43 ms	9.39 ms
`a989877`+dirty	1222.90 ms	1219.89 ms	-3.00 ms
`1faf8e3`+dirty	1223.38 ms	1220.56 ms	-2.82 ms
`75774ea`+dirty	1235.23 ms	1235.02 ms	-0.21 ms
`6e8584e`+dirty	1271.71 ms	1281.26 ms	9.55 ms
`484813b`+dirty	1225.07 ms	1221.00 ms	-4.07 ms

App size

Revision	Plain	With Sentry	Diff
`d8668ce`+dirty	2.92 MiB	3.64 MiB	742.99 KiB
`8de2810`+dirty	2.92 MiB	3.66 MiB	756.74 KiB
`1332acb`+dirty	2.92 MiB	3.67 MiB	772.45 KiB
`eb1e19f`+dirty	2.92 MiB	3.64 MiB	742.82 KiB
`61310e1`+dirty	2.92 MiB	3.66 MiB	762.99 KiB
`a989877`+dirty	2.92 MiB	3.66 MiB	757.66 KiB
`1faf8e3`+dirty	2.92 MiB	3.64 MiB	742.61 KiB
`75774ea`+dirty	2.92 MiB	3.66 MiB	763.01 KiB
`6e8584e`+dirty	2.92 MiB	3.44 MiB	536.52 KiB
`484813b`+dirty	2.92 MiB	3.64 MiB	740.56 KiB

Previous results on branch: antonis/bump-JavaScriptSDK-to-8.41.0

Startup times

Revision	Plain	With Sentry	Diff
`13fff3c`+dirty	1232.89 ms	1233.94 ms	1.05 ms
`b2b0b65`+dirty	1224.67 ms	1225.04 ms	0.38 ms

App size

Revision	Plain	With Sentry	Diff
`13fff3c`+dirty	2.92 MiB	3.67 MiB	772.04 KiB
`b2b0b65`+dirty	2.92 MiB	3.67 MiB	772.00 KiB

# Conflicts: # dev-packages/e2e-tests/package.json # samples/react-native-macos/package.json # yarn.lock

krystofwoldrich · 2024-12-12T16:12:42Z

CHANGELOG.md

 - Bump Android SDK from v7.18.0 to v7.18.1 ([#4329](https://github.com/getsentry/sentry-react-native/pull/4329))
  - [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#7181)
  - [diff](https://github.com/getsentry/sentry-java/compare/7.18.0...7.18.1)
+- Bump JavaScript SDK from v8.40.0 to v8.41.0 ([#4351](https://github.com/getsentry/sentry-react-native/pull/4351))


Let's add small ### Changes section and add - Falsy values of options.environment(empty string, undefined...) default toproduction``

Good point 👍
thank you for catching this and adding a changelog @krystofwoldrich 🙇

krystofwoldrich

LG 🚀 Let's just add a small note to change log.

krystofwoldrich · 2024-12-12T16:14:19Z

Thank you for making the JS bumps incrementally, this makes it super nice to follow the changes and to review it.

antonis · 2024-12-12T16:19:49Z

Thank you for making the JS bumps incrementally, this makes it super nice to follow the changes and to review it.

I'll follow with another PR for the 8.42.0 breaking changes before we proceed with 8.43.0. The JS SDK is moving fast 😅 🚀

antonis added 3 commits December 9, 2024 13:56

Bumps JavaScript SDK to v8.41.0

3f4974d

Updates changelog

cd9132c

Fixes broken tests

3f1e817

antonis mentioned this pull request Dec 9, 2024

Deprecates @sentry/utils #4352

Merged

10 tasks

antonis marked this pull request as ready for review December 9, 2024 12:31

antonis requested review from krystofwoldrich and lucas-zimerman as code owners December 9, 2024 12:31

antonis mentioned this pull request Dec 9, 2024

chore(deps): update JavaScript SDK to v8.44.0 #4325

Merged

Merge branch 'main' into antonis/bump-JavaScriptSDK-to-8.41.0

a1491be

# Conflicts: # dev-packages/e2e-tests/package.json # samples/react-native-macos/package.json # yarn.lock

krystofwoldrich reviewed Dec 12, 2024

View reviewed changes

krystofwoldrich approved these changes Dec 12, 2024

View reviewed changes

krystofwoldrich added 2 commits December 12, 2024 17:15

Update CHANGELOG.md

fd955cc

Merge branch 'main' into antonis/bump-JavaScriptSDK-to-8.41.0

c5024d1

krystofwoldrich enabled auto-merge (squash) December 12, 2024 16:16

krystofwoldrich merged commit 9f0f6c8 into main Dec 12, 2024

krystofwoldrich deleted the antonis/bump-JavaScriptSDK-to-8.41.0 branch December 12, 2024 16:20

Uh oh!

Conversation

antonis commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/bump-JavaScriptSDK-to-8.41.0

Startup times

App size

Uh oh!

github-actions bot commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/bump-JavaScriptSDK-to-8.41.0

Startup times

App size

Uh oh!

github-actions bot commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/bump-JavaScriptSDK-to-8.41.0

Startup times

App size

Uh oh!

github-actions bot commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/bump-JavaScriptSDK-to-8.41.0

Startup times

App size

Uh oh!

krystofwoldrich Dec 12, 2024

Choose a reason for hiding this comment

Uh oh!

antonis Dec 12, 2024

Choose a reason for hiding this comment

Uh oh!

krystofwoldrich left a comment

Choose a reason for hiding this comment

Uh oh!

krystofwoldrich commented Dec 12, 2024

Uh oh!

antonis commented Dec 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

antonis commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading