Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@
- Bump Android SDK from v8.33.0 to v8.34.0 ([#5760](https://github.com/getsentry/sentry-react-native/pull/5760))
- [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#8340)
- [diff](https://github.com/getsentry/sentry-java/compare/8.33.0...8.34.0)
- Bump Android SDK Stubs from v8.33.0 to v8.34.0 ([#5761](https://github.com/getsentry/sentry-react-native/pull/5761))
- [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#8340)
- [diff](https://github.com/getsentry/sentry-java/compare/8.33.0...8.34.0)

## 8.2.0

Expand Down
Binary file modified packages/core/android/libs/replay-stubs.jar
Binary file not shown.
2 changes: 1 addition & 1 deletion packages/core/android/replay-stubs/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ tasks.named('jar', Jar) {
}

dependencies {
compileOnly 'io.sentry:sentry:8.33.0'
compileOnly 'io.sentry:sentry:8.34.0'
Comment thread
cursor[bot] marked this conversation as resolved.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The replay-stubs.jar artifact was not rebuilt after its dependency version was updated in build.gradle, causing a version mismatch between the stubs and the declared dependency.
Severity: MEDIUM

Suggested Fix

Run yarn build or yarn build:replay-stubs to regenerate the packages/core/android/libs/replay-stubs.jar file. Commit the updated JAR file to the pull request to ensure the pre-compiled stubs match the declared dependency version.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: packages/core/android/replay-stubs/build.gradle#L21

Potential issue: The dependency version for `io.sentry:sentry` was bumped to `8.34.0` in
`replay-stubs/build.gradle`, but the pre-compiled `replay-stubs.jar` artifact was not
rebuilt and committed. The build process uses this pre-compiled JAR, which was compiled
against the older `8.33.0` version. This creates an inconsistency where new APIs from
version `8.34.0` will not be reflected in the stub classes, potentially leading to
compilation failures or runtime issues if downstream code attempts to use them.

Did we get this right? 👍 / 👎 to inform future reviews.

}
Loading