Skip to content

fix#1246: raise error when send_event failed #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sujh wants to merge 1 commit into from
Closed

fix#1246: raise error when send_event failed #1268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sentry-ruby/lib/sentry/transport.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def send_event(event)
event
rescue => e
failed_for_exception(e, event)
nil
raise e
end

def generate_auth_header
Expand Down
6 changes: 3 additions & 3 deletions sentry-ruby/spec/sentry/transport_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,12 @@
allow(subject).to receive(:send_data).and_raise(StandardError)
end

it "returns nil" do
expect(subject.send_event(event)).to eq(nil)
it "raises error" do
expect { subject.send_event(event) }.to raise_error
end

it "logs correct message" do
subject.send_event(event)
subject.send_event(event) rescue nil

log = io.string
expect(log).to match(
Expand Down