Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sentry-ruby/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- Fixes [#1307](https://github.com/getsentry/sentry-ruby/issues/1307)
- Refactor tracing implementation [#1309](https://github.com/getsentry/sentry-ruby/pull/1309)
- Allow configuring BreadcrumbBuffer's size limit [#1310](https://github.com/getsentry/sentry-ruby/pull/1310)
- Return nil from logger methods instead of breadcrumb buffer [#1299](https://github.com/getsentry/sentry-ruby/pull/1299)

## 4.2.2

Expand Down
1 change: 1 addition & 0 deletions sentry-ruby/lib/sentry/breadcrumb/sentry_logger.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ module SentryLogger
def add(*args, &block)
super
add_breadcrumb(*args, &block)
nil
Comment thread
henrahmagix marked this conversation as resolved.
end

def add_breadcrumb(severity, message = nil, progname = nil)
Expand Down
4 changes: 4 additions & 0 deletions sentry-ruby/spec/sentry/breadcrumb/sentry_logger_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@
expect(breadcrumb.message).to eq("foo")
end

it "does not affect the return of the logger call" do
expect(logger.info("foo")).to be_nil
end

it "ignores traces with #{Sentry::LOGGER_PROGNAME}" do
logger.info(Sentry::LOGGER_PROGNAME) { "foo" }

Expand Down