Skip to content

Test sentry rails integration separately #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
st0012 merged 2 commits into from
Mar 10, 2021
Merged

Test sentry rails integration separately #1321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8d7527
Test sentry-rails integraion in a separate process
st0012 Mar 10, 2021
c62bc8f
Use make test for running sentry-sidekiq's specs on CI
st0012 Mar 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/sentry_sidekiq_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,4 @@ jobs:
- name: Run specs
run: |
bundle install --jobs 4 --retry 3
bundle exec rake
make test
4 changes: 4 additions & 0 deletions sentry-sidekiq/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
build:
bundle install
gem build sentry-sidekiq.gemspec

test:
bundle exec rspec
WITH_SENTRY_RAILS=1 bundle exec rspec spec/sentry/rails_spec.rb
2 changes: 2 additions & 0 deletions sentry-sidekiq/spec/sentry/rails_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
return unless ENV["WITH_SENTRY_RAILS"]

require "rails"
require "sentry-rails"
require "spec_helper"
Expand Down