This repository was archived by the owner on Nov 20, 2023. It is now read-only.
deps: Remove webpack from peerDep and move info about ver to readme#354
Merged
Conversation
AbhiPrasad
approved these changes
Feb 16, 2022
Without peerDependencies + Meta (and optional)... I feel it's gonna be a ping-pong between packages managers issues. Why not betting on the future ?
And add a note for npm 6/7 (legacy as per their doc) recommending an update to v8 to avoid downloading webpack twice if not needed ? Would it be more future-proof ? (Maybe with a major version of the sentry webpack plugin ?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After discussing it with the team, we decided to revert this change, as the behavior of
peerDependenciesMetais not consistent across npm/yarn versions.ref: #343
ref: #350