This repository was archived by the owner on Nov 20, 2023. It is now read-only.
feat: Add function to download CLI binary#456
Merged
Conversation
Lms24
reviewed
Nov 15, 2023
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Shouldn't the plugin call the the CLI's download functionality (rather than or in addition to exporting it)?
Contributor
Author
It could, however, I would rather be able to do this from the outside in order to have more elaborate logging and error handling. For instance, if the download fails, I may not want to crash and simply skip uploading. |
Contributor
Author
|
As discussed offline, we'll for now do it this way and trial it in Next.js. If we see that it sustainably solves issues we will port this functionality to the newer plugins. If we don't have properly distributed binaries by then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export
downloadCliBinaryto download the CLI binary so it can be installed during build-time.