feat(trace-waterfall): Better UI for http.client spans
#101296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
JonasBa
reviewed
Oct 9, 2025
...c/app/views/performance/newTraceDetails/traceDrawer/details/span/eapSections/description.tsx
Outdated
Show resolved
Hide resolved
JonasBa
reviewed
Oct 9, 2025
...c/app/views/performance/newTraceDetails/traceDrawer/details/span/eapSections/description.tsx
Outdated
Show resolved
Hide resolved
Member
Author
|
@JonasBa thanks for the reminder! Switched to using |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…-the-code-source-of-http-requests
gggritso
deleted the
georgegritsouk/dain-987-add-ui-for-showing-the-code-source-of-http-requests
branch
chromy
pushed a commit
that referenced
this pull request
Oct 17, 2025
Adds some nicer handling for `http.client` spans! 1. Uses semantic attributes (`"url.full"`, `"http.request.method"`) for formatting 2. Adds a button to open the URL in a new tab, if possible 3. Adds the "source", so if the request has a known line number and file name, it appears If semantic attributes are not available, falls back to plain ho-hum formatting. Awaiting #101340 for the `wordBreak` support. **e.g.,** <img width="680" height="331" alt="Screenshot 2025-10-09 at 4 55 16 PM" src="https://github.com/user-attachments/assets/b8535b49-dcb3-44cf-a118-f0a457d09fc6" />
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some nicer handling for
http.clientspans!"url.full","http.request.method") for formattingIf semantic attributes are not available, falls back to plain ho-hum formatting.
Awaiting #101340 for the
wordBreaksupport.e.g.,
