fix(ourlogs): fetch pinned logs with a single events request - #119268
Merged
JoshuaKGoldberg merged 1 commit intoJul 9, 2026
Merged
Conversation
Collapse the two-step pinned-log fetch (selected range, then escalate out-of-range ids to a wider window) into one events request windowed to the pins' own UUIDv7 timestamps. HIGHEST_ACCURACY already guarantees no rows are dropped regardless of window width, so the id-derived window is now purely a perf optimization to keep the scan small. The per-id request batching and cache are unchanged, so unpinning one of several pins still serves the rest from cache without a refetch. Refs LOGS-905 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
Member
Author
|
@cursor review |
JoshuaKGoldberg
changed the title
events request
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit ac5cfe6. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
nsdeschenes
approved these changes
Jul 9, 2026
k-fish
approved these changes
Jul 9, 2026
JoshuaKGoldberg
deleted the
joshgoldberg/logs-905-use-events-endpoint-in-frontend
branch
July 9, 2026 15:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this, pinned logs not already in the table were fetched in two steps using the general-purpose fetcher:
But as determined this week, we can actually use the
eventsendpoint. Which is Guaranteed ™️ withsampling=HIGHEST_ACCURACYto give the logs (if they exist)! This collapses that into oneeventsrequest windowed directly to the pins' own UUIDv7 timestamps.Marking as a
fixrather than arefbecause it improves performance in the cases that needed to run the two requests.Closes LOGS-905.