Skip to content

dx(notion): Upgrade from notion to volta #13452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
billyvg merged 1 commit into from
May 30, 2019
Merged

dx(notion): Upgrade from notion to volta #13452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ install-system-pkgs: node-version-check
@echo "--> Installing system packages (from Brewfile)"
@command -v brew 2>&1 > /dev/null && brew bundle || (echo 'WARNING: homebrew not found or brew bundle failed - skipping system dependencies.')
@echo "--> Installing yarn $(YARN_VERSION) (via npm)"
@$(volta --version 2>&1 > /dev/null || notion --version 2>&1 > /dev/null || npm install -g "yarn@$(YARN_VERSION)")
@$(volta --version 2>&1 > /dev/null || npm install -g "yarn@$(YARN_VERSION)")

install-yarn-pkgs:
@echo "--> Installing Yarn packages (for development)"
Expand Down
4 changes: 0 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,6 @@
"snapshot": "build-storybook && PERCY_TOKEN=$STORYBOOK_PERCY_TOKEN PERCY_PROJECT=$STORYBOOK_PERCY_PROJECT percy-storybook --widths=1280",
"webpack-profile": "yarn -s webpack --profile --json > stats.json"
},
"toolchain": {
"node": "8.15.1",
"yarn": "1.13.0"
},
"volta": {
"node": "8.15.1",
"yarn": "1.13.0"
Expand Down