Skip to content

obs(sentry_apps): Add a small metrics increment on processing resource changes. #13897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JTCunning merged 1 commit into from
Jul 8, 2019
Merged

obs(sentry_apps): Add a small metrics increment on processing resource changes. #13897

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/sentry/tasks/sentry_apps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from sentry import features
from sentry.http import safe_urlopen
from sentry.tasks.base import instrumented_task, retry
from sentry.utils import metrics
from sentry.utils.http import absolute_uri
from sentry.api.serializers import serialize, AppPlatformEvent
from sentry.models import (
Expand Down Expand Up @@ -201,6 +202,14 @@ def _process_resource_change(action, sender, instance_id, retryer=None, *args, *
data[name] = serialize(instance)
send_webhooks(installation, event, data=data)

metrics.incr(
'resource_change.processed',
sample_rate=1.0,
tags={
'change_event': event,
}
)


@instrumented_task('sentry.tasks.process_resource_change', **TASK_OPTIONS)
@retry()
Expand Down